fix: ci(gfx11): disable embedded UI in gfx11 ROCm build - #46
Closed
roberteg16 wants to merge 1 commit into
Closed
Conversation
Skips the npm/node build and the HF dist.tar.gz download fallback, which was failing the build. llama-server still builds and serves via HTTP API. Assisted-by: Claude Opus 4
roberteg16
changed the title
Author
|
Example of failure: https://github.com/ROCm/llama.cpp/actions/runs/29242130150/job/86790397262 |
Author
|
Supersedded by: #47 This PR prefers not building the binary, competing PR prefers shipping all binaries in case any user want to use them at the expense of installing node |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-DLLAMA_BUILD_UI=OFFand-DLLAMA_USE_PREBUILT_UI=OFFto the cmake configure step inbuild-gfx11-rocm.yml.dist.tar.gzdownload fallback, which was failing the build (thelatestbucket archive is missingloading.html, sollama-ui-embederrored out).llama-serverstill builds and linksllama-ui(empty asset table), so it continues to work over the HTTP API as required by rocm-scripts.Test plan
test-gfxjob passes (llama-cli inference on gfx1151)