-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] MLABecLaplacian spherical 2d support. #4258
Draft
zhichen3
wants to merge
18
commits into
AMReX-Codes:development
Choose a base branch
from
zhichen3:mlmg_spherical
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
add support spherical 2d support for MLABecLaplacian.
Additional background
I'm trying to get add spherical 2d geometry support for MLABecLaplacian for MLMG since Castro uses the
apply()
function in MLMG to compute thermal diffusion source term. I think I mainly need to changeapplyMetricTerms()
andunapplyMetricTerms()
.I think the logic of the current code is to use$r^2$ for spherical in r-dir, and r for cylindrical in r-dir. Then $L(\phi)$ after everything is calculated, which corresponds to the 1/r^2 and 1/r outside of the derivative in divergence.
applyMetricTerms()
withinapplyMetricTermsCoeffs
to modify the coefficients by the extra geometric term from divergence, i.e.unapplyMetricTerms
is applied to the entireMy current logic is to modify the coefficient by$r^2 \sin(\theta)$ when dir=0 and $\sin(\theta)$ when dir=1, and when we unapply we divide by $\frac{1}{r^2\sin(\theta)}$ altogether, so that it is consistent with the divergence calculation.
I think I should also make sure
compResidual()
,getFluxes()
, andgetGradSolution()
to work although it doesn't affect theapply()
function.getGradSolution()
probably works since I modifiedcompGrad()
.Checklist
The proposed changes: