TagParallelFor: Fix launch bounds #4391
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We must pass block size as a template parameter to amrex::launch, otherwise the incorrect launch bounds will be used if AMREX_GPU_MAX_THREADS is set to be less than 256 at compile time.
WeiqunZhang
force-pushed
the
max_threads_128
branch
from
ec09b9e to
d61b66b
Compare
|
Pretty confident that this is ready for merge. |
AlexanderSinn
approved these changes
Apr 5, 2025
|
Merged into #4165 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We must pass block size as a template parameter to amrex::launch, otherwise the incorrect launch bounds will be used if AMREX_GPU_MAX_THREADS is set to be less than 256 at compile time.