Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NumPy 2.0 Warning, Require 2.0+ #427

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Mar 18, 2025

Fix #426: np.array(..., copy=False) to np.asarray(..., copy=False).

Bump requirements to NumPy 2.0+: we so far supported NumPy 1 & 2 in parallel, but NumPy 2 is widely enough deployed to require it now.

@ax3l ax3l added backend: openmp Specific to OpenMP execution (CPUs) warning labels Mar 18, 2025
`np.array(..., copy=False)` to `np.asarray(..., copy=False)`.

Bump requirements to NumPy 2.0+: we so far supported NumPy 1 & 2
in parallel, but NumPy 2 is widely enough deployed to require it now.
@ax3l ax3l force-pushed the fix-np2-warning branch from 6261acd to 0c674e2 Compare March 18, 2025 18:06
@ax3l ax3l changed the title Fix NumPy 2.0 Warning Fix NumPy 2.0 Warning, Require 2.0+ Mar 18, 2025
Copy link

@roelof-groenewald roelof-groenewald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I agree requiring NumPy 2 is justified at this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend: openmp Specific to OpenMP execution (CPUs) warning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modernize .to_numpy()
2 participants