Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support empty <format specific parameters> in a=fmtp: line #15

Merged
merged 3 commits into from
Nov 11, 2022

Conversation

garethsb
Copy link
Contributor

@garethsb garethsb commented Aug 26, 2022

Proposed fix for #14.

Note that there's still more to do to bring ST 2110-40 testing up to same level as ST 2110-20, see #4.
And #11 is required ASAP as well, now the ST 2110-xx:2022 revisions are imminent.

@garethsb
Copy link
Contributor Author

garethsb commented Aug 26, 2022

Note that there's still the existing bug that if the a=fmtp: line appears before the a=rtpmap: line, e.g. test_20_72_1 fails because extractMTParams doesn't work out it needs to skip the format specific parameter checks in time. Luckily, all files I've seen in the wild order rtpmap before fmtp.

Copy link

@pedro-alves-ferreira pedro-alves-ferreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

checkST2110.js Outdated Show resolved Hide resolved
@garethsb garethsb merged commit fc1090b into master Nov 11, 2022
@garethsb garethsb deleted the garethsb-patch-fmtp branch November 11, 2022 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants