feat: implement automatic royalty payment enforcement on NFT transfers#64
Open
ReinaMaze wants to merge 4 commits intoANYTECHS:mainfrom
Open
feat: implement automatic royalty payment enforcement on NFT transfers#64ReinaMaze wants to merge 4 commits intoANYTECHS:mainfrom
ReinaMaze wants to merge 4 commits intoANYTECHS:mainfrom
Conversation
- Override transfer function to require sale_price parameter - Automatically calculate and enforce royalty payments during transfer - For custom assets: automatically transfer royalty from seller to recipients - For XLM: emit RoyaltyPaid events (marketplace handles actual payment) - Support multi-recipient royalty splits with accurate calculation - Add comprehensive tests for automatic enforcement - Add validation for zero/negative sale prices - Add overflow protection for royalty calculations - Update all existing transfer calls with sale_price parameter All 45 tests passing successfully.
|
@ReinaMaze Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
- Confirms successful merge of automatic royalty enforcement feature - Documents all changes and acceptance criteria met - All 45 tests passing
ReinaMaze
force-pushed
the
feature/automatic-royalty-enforcement
branch
from
18e060c to
23059b3
Compare
- Override transfer function to require sale_price parameter - Automatically calculate and enforce royalty payments during transfer - For custom assets: automatically transfer royalty from seller to recipients - For XLM: emit RoyaltyPaid events (marketplace handles actual payment) - Support multi-recipient royalty splits with accurate calculation - Add comprehensive tests for automatic enforcement - Add validation for zero/negative sale prices - Add overflow protection for royalty calculations Acceptance Criteria: Override transfer function to calculate and handle royalty Emit RoyaltyPaid event Support native XLM and custom asset payments All 45 tests passing successfully.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All 45 tests passing successfully.
close #6