Fix: Combine global and local search with AND logic#305
Merged
Eniola3321 merged 2 commits intoANYTECHS:mainfrom Apr 29, 2026
Merged
Fix: Combine global and local search with AND logic#305Eniola3321 merged 2 commits intoANYTECHS:mainfrom
Eniola3321 merged 2 commits intoANYTECHS:mainfrom
Conversation
|
@kingjosmel Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Combine Global and Local Search with AND Logic
close #221
Problem
When both the global header search and local table search were active, the local search was silently ignored. Users typing in the table search input while a global search was active would see no effect with no visual explanation.
Solution
Updated
EarningsTable.tsxto combine both search filters using AND logic instead of OR, ensuring transactions must match both active searches simultaneously.Changes
ORtoAND— both searches now work togethermatchesSearchTerm()to check transaction matches against search termsAcceptance Criteria ✅