Open
Conversation
Let the launcher handle wallpaper selection. Change-Id: I7f0eb20a5bc01d82fdb98905524b9743fee447c6 Signed-off-by: Roman Birg <roman@cyngn.com> Conflicts: res/xml/display_settings.xml
Add needed extras to launch subscription selection. Change-Id: I568666477fe9a5cf566fd94475f8d2a5ebf768e1
* All these settings are under a 'Volume buttons' header. Avoiding duplication of 'Volume button' makes it easier for translators Change-Id: I51eb2de69c2f038f13d95a8e97bde1ecf83df913 Conflicts: res/values/cm_strings.xml
* Cleanup display settings ghetto:
- Move Brightness to the top
- Replace the single-option menu with a switch in cast screen
- Create display category
- Move Cast Screen to higher priority, move down Daydream and Font
- Create advanced category
- Relocate advanced stuff to the bottom, including DoubleTap to wake
* Move gesture settings so it doesn't look like it's part of expanded
desktop's category
* Use a seekbar preference to allow setting arbitrary animation scale values
Todo (depend on outstanding draft patches) :
- Remove Lockscreen wallpaper option from Lockscreen settings
- Use new ThemeChooser instead
- Kill Trebuchet sub-settings from Home settings
Change-Id: I4ceaf0dc74e6e044e36cf3652bfc1efb33890380
Conflicts:
res/xml/display_settings.xml
src/com/android/settings/DisplaySettings.java
This reverts commit 1ef9bcb.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi hany,
I have used your master branch now to add the missing commits.
"settings: Various cleanups" is not useful at all. Had to revert this.
Cheers!