Skip to content

Improve currency info dataset#158

Merged
mdrlzy merged 7 commits into
mainfrom
feature/improve-currency-dataset
Jul 22, 2025
Merged

Improve currency info dataset#158
mdrlzy merged 7 commits into
mainfrom
feature/improve-currency-dataset

Conversation

@mdrlzy

@mdrlzy mdrlzy commented Jul 4, 2025

Copy link
Copy Markdown
Collaborator

📌 Description

Added two JSON files to res/raw:

  • code_name.json – maps currency codes to currency names

  • code_country.json – maps currency codes to a list of countries

Introduced CurrencyInfoDataSource:

  • Loads JSON files

Updated CurrencyRepoImpl to:

  • Сaches currency info

  • Provide CurrencyInfo for available CurrencyRate entries

Updated SearchUseCase to:

  • Search currency by country

🎯 How to Test

Testing search by country:

  • Try searching for Micronesia - it should return the USD currency
  • You can find similar country-to-currency mappings in code_country.json to test other cases.

🔗 Related Tickets / Issues

Ensure cryptocurrencies have names

@mdrlzy

mdrlzy commented Jul 4, 2025

Copy link
Copy Markdown
Collaborator Author

Blocked by #147 and #154

@mdrlzy mdrlzy marked this pull request as draft July 4, 2025 11:24
@mdrlzy mdrlzy changed the title Feature/improve currency dataset Improve currency info dataset Jul 6, 2025
@mdrlzy mdrlzy force-pushed the feature/improve-currency-dataset branch from fcb53df to 798e273 Compare July 15, 2025 21:37
@mdrlzy mdrlzy marked this pull request as ready for review July 15, 2025 21:37
@mdrlzy mdrlzy requested a review from shubertm July 16, 2025 08:38
@mdrlzy mdrlzy merged commit d183f91 into main Jul 22, 2025
4 checks passed
@mdrlzy mdrlzy deleted the feature/improve-currency-dataset branch July 22, 2025 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants