Dedicated link creation dialog#41
Closed
mberry wants to merge 13 commits into
Closed
Conversation
…range frontend files
Also removed the static ARK_SHELF_DATA_PATH Added the yarn clean script to clean the cargo cache
Will also open on ctrl+v and paste the url Only shows url field at first, then autofills with title Has a 1500ms debounce to keep it from opening prematurely if the user is typing the address. Closes dialog form after link created
gwendalF
force-pushed
the
feature/vitejs-svelte
branch
from
be6c40d to
def6b81
Compare
Member
|
Is it correct to imagine that the "AUTO FILLED" button is invisible now and it automatically pressed every 1.5s? |
Author
|
It sets a timer the moment a key is pressed, if the key is pressed again it resets. If the timer hits zero it makes the network connection to autofill. |
Member
|
@mberry we need update this PR to catch up with |
Author
|
Replaced by #47 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added save button which opens link creation form
Will also open on ctrl+v and paste the url
Only shows url field at first, then autofills with title
Has a 1500ms debounce to keep it from opening prematurely if the user
is typing the address.
Closes dialog form after link created