Skip to content

#33, #40: Allow urls without schemes#48

Open
mberry wants to merge 2 commits into
mainfrom
Allow-URLs-without-schemes
Open

#33, #40: Allow urls without schemes#48
mberry wants to merge 2 commits into
mainfrom
Allow-URLs-without-schemes

Conversation

@mberry

@mberry mberry commented Oct 1, 2023

Copy link
Copy Markdown

Will try parse with http://
If that fails will raise an error

Closes:

mberry added 2 commits October 1, 2023 12:46
Will try parse with http://
If that fails will raise an error
@mberry

mberry commented Oct 1, 2023

Copy link
Copy Markdown
Author

So the build.yaml script is also running a lint script through pnpm

This should probably be an entirely separate CI script for linting/format as the build is outputting a binary, not source code.

Anyway because of this:

-use url::{Url, ParseError};
+use url::{ParseError, Url};

the build failed, I will fix it and push again.

@kirillt

kirillt commented Oct 2, 2023

Copy link
Copy Markdown
Member

Probably we should try parsing with https, too:

1.mp4

Also weird little bug (separate issue):

2.mp4

@kirillt kirillt assigned mberry and rizary and unassigned mberry Oct 16, 2023
@rizary

rizary commented Jan 21, 2024

Copy link
Copy Markdown

I'm planning to work on this after finish #50, what's the context of this issue? we can just put github.com instead https://github.com/ right?

@kirillt

kirillt commented Jan 21, 2024

Copy link
Copy Markdown
Member

@rizary I'm not sure. Does a link without scheme really can be queried? I guess, it defaults either to http or to https..

@kirillt kirillt changed the title Allow urls without schemes #33, #40: Allow urls without schemes Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants