#33, #40: Allow urls without schemes#48
Open
mberry wants to merge 2 commits into
Open
Conversation
Will try parse with http:// If that fails will raise an error
Author
|
So the build.yaml script is also running a lint script through pnpm This should probably be an entirely separate CI script for linting/format as the build is outputting a binary, not source code. Anyway because of this: -use url::{Url, ParseError};
+use url::{ParseError, Url};the build failed, I will fix it and push again. |
Member
|
Probably we should try parsing with 1.mp4Also weird little bug (separate issue): 2.mp4 |
|
I'm planning to work on this after finish #50, what's the context of this issue? we can just put |
Member
|
@rizary I'm not sure. Does a link without scheme really can be queried? I guess, it defaults either to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will try parse with http://
If that fails will raise an error
Closes: