Disable small versions of ctype functions #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
statham-arm
reviewed
Jan 19, 2024
picolibc/picolibc@43a3894 adds support for a small ctype implementation -- an inline version which performs direct character value comparisons without needing a table. However this implementation does not support locales or extended character sets needed by libc++. Therefore fallback to the classic, table based ctype implementation.
amilendra
force-pushed
the
disable-small-ctype
branch
from
5d35fe2 to
de461c0
Compare
statham-arm
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
picolibc/picolibc@43a3894 adds support for a small ctype implementation -- an inline version which performs direct character value comparisons without needing a table.
However this implementation does not support locales or extended character sets. Therefore fallback to the classic, table based ctype implementation.