Python3 compatibility fix for end of urlopen read #969
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 6, 2020
oxzi
added a commit
to oxzi/armmbed-docker
that referenced
this pull request
Jul 3, 2020
Downloading libraries is broken in both mbed-cli's latest release and HEAD for Python 3. There is a PR, which is now included as a patch[0]. Sigh. [0]:ARMmbed/mbed-cli#969
|
It would be great to get it merged (+ other Python 3 fixes - seems like there are a few remaining issues). On my end I can confirmed that this change unblocked my |
0xc0170
approved these changes
Apr 6, 2021
|
@ARMmbed/mbed-os-core Please review |
Patater
approved these changes
Apr 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #968. Context:
Hence the check used to work on Py2 only (for Py3, it would enter an infinite loop after hitting the end of the file). It should now work on both Py2 and Py3.