Fix: ActiveRocketPy bug fix - #157
Merged
Merged
Conversation
zuorenchen
added a commit
that referenced
this pull request
Aug 29, 2026
* Write down that the launch step's control fields are not applied Closes #80, as decided there: document the behaviour and leave the implementation alone. The rocket is still on the rail on the step that launches, so `tvc`, `throttle` and `roll` would not change where it goes. That step builds the flight from the launch attitude and the step after it is the first that applies them. Two lines, one in the README where the action space is described and one in `step()` where a reader would ask. Signed-off-by: thc1006 <84045975+thc1006@users.noreply.github.com> * Say why an action field was ignored The catch around the conversion is broad on purpose, and the log line it fed said only that a field was ignored. A competitor sending a string and a defect in the four lines above it produced the same sentence, so the defect was invisible. The reason travels with the field name now: Step 42: ignoring tvc, which the environment cannot use: ValueError: could not convert string to float: 'x' (1 such steps for that field) check_action still answers with a sorted list of names, since that is what an agent calls. Signed-off-by: thc1006 <84045975+thc1006@users.noreply.github.com> * Record what landed after v0.1.1 The Unreleased section was empty again within the hour, which is the drift #134 existed to stop. Two entries, for #131 and #126. Signed-off-by: thc1006 <84045975+thc1006@users.noreply.github.com> * Put a placeholder where the example carried a real secret example_eval_cfg.yaml and the README both shipped a working team_secret. A credential does not belong in an example, and a competitor has to replace it with their own anyway, so the file now says what to paste instead of shipping something that already works. No behaviour changes. The secret is only ever copied into the packed submission, and nothing reads its value. Signed-off-by: thc1006 <84045975+thc1006@users.noreply.github.com> * Fix inclination indication in readme fig (#153) * ENH: Add wall time limit (#154) * Add wall time limit * Update tests * Update the suggestions from PR review * Start the episode clock on the same one step reads, and pin it (#156) * Start the episode clock on the same one step reads reset() started it on time.time() while step() measured with time.monotonic(), so the difference was about -1.8e9 and no episode could reach any limit. Signed-off-by: thc1006 <84045975+thc1006@users.noreply.github.com> * Pin the wall clock limit with the test that would have caught it Nothing in tests/ mentioned max_wall_time, and a limit that can never fire looks exactly like a limit nobody reached. Signed-off-by: thc1006 <84045975+thc1006@users.noreply.github.com> --------- Signed-off-by: thc1006 <84045975+thc1006@users.noreply.github.com> --------- Signed-off-by: thc1006 <84045975+thc1006@users.noreply.github.com> Co-authored-by: 秀吉 <84045975+thc1006@users.noreply.github.com> * Refuse to pack a submission from a run that never finished (#142) * Refuse to pack a submission from a run that never finished build_submission_payload reads the score and the trajectories straight off the environment, and nothing said whether the episode had reached an ending. A run stopped part way through produced a submission that looked exactly like a complete one, carrying whatever score it had reached by then. Measured on scenario 0: five steps in, with the rocket still on the pad, the payload came out fully formed and leaderboard_info had no field that mentioned the run being unfinished. The environment now records how the episode ended, reset clears it, the payload carries it along with the step count, and pack_for_submission refuses a run that never got there. Which of terminated and truncated should score is #104 and is not decided here; this only asks whether the episode reached an ending at all. The fake environments in the submission tests gain the same two fields. They document themselves as the attributes pack_for_submission reads, and that set grew. Signed-off-by: thc1006 <84045975+thc1006@users.noreply.github.com> * Clean up comments --------- Signed-off-by: thc1006 <84045975+thc1006@users.noreply.github.com> Co-authored-by: zuorenchen <zuorenchen@m110.nthu.edu.tw> Co-authored-by: ZuoRen Chen <180084773+zuorenchen@users.noreply.github.com> * Fix pylints * docs: make README setup commands cross-platform (#138) * docs: make README setup commands cross-platform * Potential fix for pull request finding --------- Co-authored-by: 秀吉 <84045975+thc1006@users.noreply.github.com> Co-authored-by: ZuoRen Chen <180084773+zuorenchen@users.noreply.github.com> * Revert "Put a placeholder where the example carried a real secret" (#159) * Fix: ActiveRocketPy bug fix (#157) * Update ActiveRocketPy submodule to fix TVC and acclerometer bug * Fix the incorrect accelerometer model following the updates in ActiveRocketPy * Regenerate scenario 0 and 1 baselines * Bump submission version to 2 (#160) * Update changelog for v0.2.0 --------- Signed-off-by: thc1006 <84045975+thc1006@users.noreply.github.com> Co-authored-by: thc1006 <84045975+thc1006@users.noreply.github.com> Co-authored-by: William Mou <william.mou1024@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.