Open
Conversation
…etime_comment fix comment about datehour -> datetime
…_value_into_conf_global_key fix Dolibarr#27883 : zero could be a value stored
Backport the pre-commit tool to bring extra checks to the older versions so that they are fixed earlier before merging in upper versions. Other PRs will be created for backporting to 18.0 and 19.0. The PRs should be accepted in reverse order: - develop; - 19.0: - 18.0; - 17.0. That should avoid merge conflicts and ensure that options (and ignored messages or steps) are adapted to the version branch.
…r#28018) This change to the workflow will run phpcs on all files in develop, 17.0, 18.0, ... (rule== branch ends in .0). This ensures that phpcs is run in a github workflow for fast phpcs issue detection in the develop and other main branches. Ultimately, this means that the PHPCS action can be disabled in branches where it is active. But I propose to verify that the updated action does the job as expected (tested in a fork it is ok).
Co-authored-by: Noé <[email protected]>
Conflicts: htdocs/takepos/invoice.php
Conflicts: htdocs/takepos/invoice.php
Conflicts: htdocs/core/class/extrafields.class.php
Conflicts: htdocs/core/class/extrafields.class.php
* FIX CVE-2024-23817 * FIX syntax error
* FIX CVE-2024-23817 * FIX syntax error --------- Co-authored-by: Regis Houssin <[email protected]>
…n does (Dolibarr#28087) * FIX: Bar code verification should be done by entity because generation does * FIX: handle Entities shared tables * FIX: Remove unused global --------- Co-authored-by: Noé <[email protected]>
* Qual: Lower severity on php-cs messages that should not block (Dolibarr#28072) # Qual: Lower severity on php-cs messages that should not block Some warning messages result in php-cs having an exit code of 2 and others only have an exit ocde of 1. When the exit code is 2, the warnings are fixable by php-cbf. In order to be able to filter on the warnings in the github ci flow, but still show them in the travis flow, I lower the level of the warnings that should not be blocking to 4. At the same time, the php-cs configuration in pre-commit now requires that the severity is minimum 5 to show the message (level 5 is the default for all warnings and errors). So this will limit the warning messages to the ones that should result in a failing ci action. If any new cases are discovered, they should also be lowered in the php-cs configuration file. * Qual: ci: Run pre-commit/php-cs with cache (Dolibarr#28079) This adds a hook to .pre-commit-config.yaml and updates the workflow to run php-cs with cache when it is run for all files. When running on changed files only, the cache is not useful. The php-codesniffer ruleset.xml was cleaned up (duplicates removal/formatted)
For this hook to add reasonable additional fields to a line, access to the line number and other related values of the line is required.
* better fix with this->entity thanks to regis * Update fichinter.class.php --------- Co-authored-by: Laurent Destailleur <[email protected]>
Conflicts: htdocs/core/class/commonobject.class.php
…8614) * Qual: ci: Run pre-commit/php-cs with cache (Dolibarr#28079) This adds a hook to .pre-commit-config.yaml and updates the workflow to run php-cs with cache when it is run for all files. When running on changed files only, the cache is not useful. The php-codesniffer ruleset.xml was cleaned up (duplicates removal/formatted) * Fix: Make all 'relative paths' absolute (Dolibarr#28196) # Fix: Make all 'relative paths' absolute The phpcs ruleset xml file's relative exclude patterns are relative to the filename(s) provided on the command line. Hence with partial verifications, the path exclusion does not function as we would like. Removing the relative-path attribute from the patterns the exclusion works. At the same time, the patterns were optimized and a comment was added. * Qual: Optimize workflow (Dolibarr#28386) # Qual: Optimize workflow The log annotation based on the pre-commit logs is now simplified.
* FIX: The minimum price in proposals is not checked correctly * Fix: Deposit lines are not created correctly * Fix: Volver a dejar como estaba * Fix: Deposit lines are not created correctly
…ding to inconsistencies if BILL_SUPPLIER_VALIDATE changes the invoice's ref (Dolibarr#28684) this is a follow-up of PR Dolibarr#27008
…barr#28753) * FIX Dolibarr#24265 regression cannot see all product on takepose See discussion here : https://www.dolibarr.fr/forum/t/bug-affichage-takepos-mobile-dolibarr-v17/43219 * Update pos.css.php --------- Co-authored-by: Laurent Destailleur <[email protected]>
…_koesio_17.0.4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
19 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cette PR est juste là pour merge la 17.0 standard dans la 17.0_koesio, mais ⚠ la 17.0 standard est passée en 17.0.4 donc montée de version mineure à prévoir !