Add MuJoCo/BSK_Sim thruster arm control example#1311
Open
Will-Schwend wants to merge 8 commits intodevelopfrom
Open
Add MuJoCo/BSK_Sim thruster arm control example#1311Will-Schwend wants to merge 8 commits intodevelopfrom
Will-Schwend wants to merge 8 commits intodevelopfrom
Conversation
Will-Schwend
added a commit
that referenced
this pull request
Mar 6, 2026
5808f25 to
abbe90b
Compare
Will-Schwend
added a commit
that referenced
this pull request
Mar 6, 2026
Will-Schwend
added a commit
that referenced
this pull request
Mar 6, 2026
Will-Schwend
added a commit
that referenced
this pull request
Mar 6, 2026
Will-Schwend
added a commit
that referenced
this pull request
Mar 6, 2026
Will-Schwend
added a commit
that referenced
this pull request
Mar 6, 2026
Will-Schwend
added a commit
that referenced
this pull request
Mar 9, 2026
abbe90b to
33e3efd
Compare
Will-Schwend
added a commit
that referenced
this pull request
Mar 9, 2026
Will-Schwend
added a commit
that referenced
this pull request
Mar 9, 2026
Will-Schwend
added a commit
that referenced
this pull request
Mar 9, 2026
Will-Schwend
added a commit
that referenced
this pull request
Mar 9, 2026
Will-Schwend
added a commit
that referenced
this pull request
Mar 9, 2026
Will-Schwend
added a commit
that referenced
this pull request
Mar 9, 2026
Will-Schwend
added a commit
that referenced
this pull request
Mar 9, 2026
Will-Schwend
added a commit
that referenced
this pull request
Mar 9, 2026
Will-Schwend
added a commit
that referenced
this pull request
Mar 9, 2026
Will-Schwend
added a commit
that referenced
this pull request
Mar 9, 2026
33e3efd to
fa14310
Compare
Will-Schwend
added a commit
that referenced
this pull request
Mar 9, 2026
Will-Schwend
added a commit
that referenced
this pull request
Mar 9, 2026
Will-Schwend
added a commit
that referenced
this pull request
Mar 9, 2026
Will-Schwend
added a commit
that referenced
this pull request
Mar 9, 2026
Will-Schwend
added a commit
that referenced
this pull request
Mar 12, 2026
Will-Schwend
added a commit
that referenced
this pull request
Mar 12, 2026
f4855a5 to
793d7bf
Compare
Will-Schwend
added a commit
that referenced
this pull request
Mar 12, 2026
Will-Schwend
added a commit
that referenced
this pull request
Mar 12, 2026
Will-Schwend
added a commit
that referenced
this pull request
Mar 12, 2026
Will-Schwend
added a commit
that referenced
this pull request
Mar 12, 2026
Will-Schwend
added a commit
that referenced
this pull request
Mar 13, 2026
Will-Schwend
added a commit
that referenced
this pull request
Mar 13, 2026
Will-Schwend
added a commit
that referenced
this pull request
Mar 13, 2026
793d7bf to
c022b53
Compare
Will-Schwend
added a commit
that referenced
this pull request
Mar 13, 2026
Will-Schwend
added a commit
that referenced
this pull request
Mar 13, 2026
Will-Schwend
added a commit
that referenced
this pull request
Mar 13, 2026
Will-Schwend
added a commit
that referenced
this pull request
Mar 13, 2026
Contributor
Author
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c022b5308a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
schaubh
requested changes
Mar 13, 2026
c022b53 to
0ba04ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new MuJoCo example scenario,
examples/mujoco/scenarioThrArmControl.py, along with MuJoCo-specific BSK-style master/model wiring and support modules for thruster-on-arm control.Approach taken:
scenarioThrArmControl.pyexamples/mujoco/BSK_mujocoMasters.pyexamples/mujoco/mujocoModels/BSK_MujocoDynamics.pyexamples/mujoco/mujocoModels/BSK_MujocoFSW.pyexamples/mujoco/thrArmControlSupport:jointThrAllocation.pythrFiringRound.pystateMerge.pyinertialCartFeedbackVerification
Validation artifacts included in this branch:
test_scenarioMujoco.pyruns the new scenario.Test intent:
Documentation
Documentation updated for all added components:
examples/mujoco/scenarioThrArmControl.py(scenario narrative and figures in docstring)examples/_default.rst(scenario indexing)docs/source/Support/bskReleaseNotes.rst(release-note entries)