Skip to content

Add MuJoCo/BSK_Sim thruster arm control example#1311

Open
Will-Schwend wants to merge 8 commits intodevelopfrom
feature/scenarioThrArmControl
Open

Add MuJoCo/BSK_Sim thruster arm control example#1311
Will-Schwend wants to merge 8 commits intodevelopfrom
feature/scenarioThrArmControl

Conversation

@Will-Schwend
Copy link
Contributor

@Will-Schwend Will-Schwend commented Mar 6, 2026

  • Review: By commit
  • Merge strategy: Merge (no squash)

Description

This PR adds a new MuJoCo example scenario, examples/mujoco/scenarioThrArmControl.py, along with MuJoCo-specific BSK-style master/model wiring and support modules for thruster-on-arm control.

Approach taken:

  • Added new example scneario file scenarioThrArmControl.py
  • Added MuJoCo BSK scaffolding:
    • examples/mujoco/BSK_mujocoMasters.py
    • examples/mujoco/mujocoModels/BSK_MujocoDynamics.py
    • examples/mujoco/mujocoModels/BSK_MujocoFSW.py
  • Added python modules in examples/mujoco/thrArmControlSupport:
    • jointThrAllocation.py
    • thrFiringRound.py
    • stateMerge.py
  • Removed unneeded variable from inertialCartFeedback

Verification

Validation artifacts included in this branch:

  • test_scenarioMujoco.py runs the new scenario.

Test intent:

  • Assert test runs and produces figures for documentation.

Documentation

Documentation updated for all added components:

  • examples/mujoco/scenarioThrArmControl.py (scenario narrative and figures in docstring)
  • examples/_default.rst (scenario indexing)
  • docs/source/Support/bskReleaseNotes.rst (release-note entries)

@Will-Schwend Will-Schwend requested a review from a team as a code owner March 6, 2026 17:58
@Will-Schwend Will-Schwend marked this pull request as draft March 6, 2026 17:58
@Will-Schwend Will-Schwend force-pushed the feature/scenarioThrArmControl branch from 5808f25 to abbe90b Compare March 6, 2026 18:05
Will-Schwend added a commit that referenced this pull request Mar 6, 2026
Will-Schwend added a commit that referenced this pull request Mar 6, 2026
@Will-Schwend Will-Schwend moved this to 🏗 In progress in Basilisk Mar 6, 2026
@Will-Schwend Will-Schwend added the enhancement New feature or request label Mar 6, 2026
@Will-Schwend Will-Schwend self-assigned this Mar 6, 2026
@Will-Schwend Will-Schwend force-pushed the feature/scenarioThrArmControl branch from abbe90b to 33e3efd Compare March 9, 2026 16:58
Will-Schwend added a commit that referenced this pull request Mar 9, 2026
Will-Schwend added a commit that referenced this pull request Mar 9, 2026
Will-Schwend added a commit that referenced this pull request Mar 9, 2026
Will-Schwend added a commit that referenced this pull request Mar 9, 2026
Will-Schwend added a commit that referenced this pull request Mar 9, 2026
Will-Schwend added a commit that referenced this pull request Mar 9, 2026
@Will-Schwend Will-Schwend force-pushed the feature/scenarioThrArmControl branch from 33e3efd to fa14310 Compare March 9, 2026 17:23
Will-Schwend added a commit that referenced this pull request Mar 9, 2026
Will-Schwend added a commit that referenced this pull request Mar 12, 2026
@Will-Schwend Will-Schwend force-pushed the feature/scenarioThrArmControl branch from f4855a5 to 793d7bf Compare March 12, 2026 18:37
Will-Schwend added a commit that referenced this pull request Mar 12, 2026
Will-Schwend added a commit that referenced this pull request Mar 12, 2026
Will-Schwend added a commit that referenced this pull request Mar 13, 2026
@Will-Schwend Will-Schwend force-pushed the feature/scenarioThrArmControl branch from 793d7bf to c022b53 Compare March 13, 2026 17:40
Will-Schwend added a commit that referenced this pull request Mar 13, 2026
Will-Schwend added a commit that referenced this pull request Mar 13, 2026
@Will-Schwend Will-Schwend marked this pull request as ready for review March 13, 2026 17:40
@Will-Schwend
Copy link
Contributor Author

@codex review

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c022b5308a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Will-Schwend Will-Schwend moved this from 🏗 In progress to 👀 In review in Basilisk Mar 13, 2026
@schaubh schaubh self-requested a review March 13, 2026 19:21
@Will-Schwend Will-Schwend force-pushed the feature/scenarioThrArmControl branch from c022b53 to 0ba04ce Compare March 18, 2026 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: 👀 In review

Development

Successfully merging this pull request may close these issues.

2 participants