-
Notifications
You must be signed in to change notification settings - Fork 102
Introduction of downlinkHandling module to communication architecture #1323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
dhutererprats
wants to merge
10
commits into
develop
Choose a base branch
from
downlinkHandling
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,220
−0
Draft
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
312fcdc
[#1323] add core downlinkHandling module
dhutererprats fe3962a
[#1323] add DownlinkHandlingMsgPayload
dhutererprats f038337
[#1323] add module code description
dhutererprats 29b93d0
[#1323] add downlinkHandling documentation
dhutererprats d7867d0
[#1323] add module unit test
dhutererprats ed8e90c
[#1323] updated rst docs
dhutererprats 2084f66
[#1323] add downlinkHandling diagrams and figures
dhutererprats 29b5339
[#1323] downlinkHandling: harden interface and add removal policy
dhutererprats 42a7062
[#1323] downlinkHandling: expand unit tests and add debug toggle
dhutererprats 1ffe531
[#1323] downlinkHandling: refine module docs and add release note sni…
dhutererprats File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
3 changes: 3 additions & 0 deletions
3
docs/source/Support/bskReleaseNotesSnippets/downlinkHandling.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| - Added :ref:`downlinkHandling` with a validated configuration interface (setters/getters), finite-value guards, and bounded outputs to prevent non-physical downlink rates. | ||
| - Added :ref:`DownlinkHandlingMsgPayload` diagnostics and dedicated unit-test coverage for equation parity, receiver-path selection, storage-limited behavior, and invalid-input handling. | ||
| - Improved storage-target selection robustness across connected storage status messages and aligned module documentation with implemented behavior and validation interface. |
59 changes: 59 additions & 0 deletions
59
src/architecture/msgPayloadDefC/DownlinkHandlingMsgPayload.h
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| /* | ||
| ISC License | ||
|
|
||
| Copyright (c) 2026, Autonomous Vehicle Systems Lab, University of Colorado Boulder | ||
|
|
||
| Permission to use, copy, modify, and/or distribute this software for any | ||
| purpose with or without fee is hereby granted, provided that the above | ||
| copyright notice and this permission notice appear in all copies. | ||
|
|
||
| THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES | ||
| WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF | ||
| MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR | ||
| ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES | ||
| WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN | ||
| ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF | ||
| OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. | ||
|
|
||
| */ | ||
|
|
||
| #ifndef BASILISK_DOWNLINKHANDLINGMSG_H | ||
| #define BASILISK_DOWNLINKHANDLINGMSG_H | ||
|
|
||
| #include <stdint.h> | ||
|
|
||
| /*! @brief Message for reporting downlink performance and data handling metrics */ | ||
| typedef struct { | ||
| uint32_t linkActive; //!< [-] 1 if link-quality inputs are valid for downlink calculations | ||
| uint32_t receiverIndex; //!< [-] Selected receiver antenna index (1, 2) or 0 if none | ||
| uint64_t maxRetransmissions; //!< [-] Maximum ARQ retransmission attempts per packet | ||
| uint32_t removalPolicy; //!< [-] Storage-removal policy (0=REMOVE_ATTEMPTED, 1=REMOVE_DELIVERED_ONLY) | ||
| char transmitterAntennaName[20]; //!< [-] Name of the selected transmitting antenna | ||
| char receiverAntennaName[20]; //!< [-] Name of the selected receiving antenna | ||
| char dataName[128]; //!< [-] Name of the data partition currently downlinked | ||
| double timeStep; //!< [s] Module integration timestep | ||
| double bandwidth; //!< [Hz] Link overlap bandwidth used in the calculation | ||
| double bitRateRequest; //!< [bit/s] Requested channel bit rate | ||
| double packetSizeBits; //!< [bit] Packet size used for BER-to-PER conversion | ||
| double cnr; //!< [-] Selected C/N ratio (linear) | ||
| double cnr_dB; //!< [dB] Selected C/N ratio in decibel | ||
| double cNo_dBHz; //!< [dBHz] Carrier-to-noise density ratio | ||
| double ebN0_dB; //!< [dB] Energy-per-bit to noise-density ratio | ||
| double ber; //!< [-] Bit error rate | ||
| double per; //!< [-] Packet error rate | ||
| double packetSuccessProb; //!< [-] Packet success probability within max retransmissions | ||
| double packetDropProb; //!< [-] Packet drop probability within max retransmissions | ||
| double expectedAttemptsPerPacket; //!< [-] Expected number of attempts needed to complete one source packet | ||
| double attemptedDataRate; //!< [bit/s] Attempted channel transmission rate including retransmissions | ||
| double storageRemovalRate; //!< [bit/s] Data removed from spacecraft storage per selected removal policy | ||
| double deliveredDataRate; //!< [bit/s] Data delivered successfully to receiver | ||
| double droppedDataRate; //!< [bit/s] Data dropped after reaching retransmission limit | ||
| double availableDataBits; //!< [bit] Data available in selected storage partition at start of step | ||
| double estimatedRemainingDataBits; //!< [bit] Estimated remaining data in selected partition after this step | ||
| double cumulativeAttemptedBits; //!< [bit] Cumulative attempted bits including retransmissions | ||
| double cumulativeRemovedBits; //!< [bit] Cumulative bits removed from storage | ||
| double cumulativeDeliveredBits; //!< [bit] Cumulative successfully delivered bits | ||
| double cumulativeDroppedBits; //!< [bit] Cumulative dropped bits | ||
| } DownlinkHandlingMsgPayload; | ||
|
|
||
| #endif |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| target_link_libraries(${TARGET_NAME} PRIVATE onboardDataHandlingLib) |
64 changes: 64 additions & 0 deletions
64
...n/communication/downlinkHandling/_Documentation/Images/DownlinkHandlingFlow.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
64 changes: 64 additions & 0 deletions
64
...ion/downlinkHandling/_Documentation/Images/DownlinkHandlingReliabilityChain.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This figure does not look rendered correctly!
(Text overflows the boxes)
Also the last box (Storage Gate) does not point to anything!