Skip to content

[#294] Fix multiple rewarders of same type#295

Merged
Mark2000 merged 1 commit intodevelopfrom
bugfix/294-multiple-rewarders
Jul 14, 2025
Merged

[#294] Fix multiple rewarders of same type#295
Mark2000 merged 1 commit intodevelopfrom
bugfix/294-multiple-rewarders

Conversation

@Mark2000
Copy link
Copy Markdown
Contributor

@Mark2000 Mark2000 commented Jul 3, 2025

Description

Closes #294

Fixes bug.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How should this pull request be reviewed?

  • By commit
  • All changes at once

How Has This Been Tested?

Fixes bug.

Future Work

None.

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation and release notes
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Copilot AI review requested due to automatic review settings July 3, 2025 18:26
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Fixes a bug where multiple rewarders of the same type would overwrite each other’s settings by changing the way data_store_kwargs are passed and handled.

  • Switched ComposedDataStore’s data_store_kwargs parameter from a dict to a list and zipped it with data_store_types.
  • Updated create_data_store to pass a list of kwargs instead of a dict.
  • Documented the fix in the release notes.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
src/bsk_rl/data/composition.py Changed data_store_kwargs to a list, updated constructor and call site.
docs/source/release_notes.rst Added an entry about fixing multiple-rewarder overwrite issues.

@Mark2000 Mark2000 force-pushed the bugfix/294-multiple-rewarders branch from ad65899 to a518f90 Compare July 3, 2025 18:33
@Mark2000 Mark2000 requested a review from AnaisCheval July 14, 2025 17:36
@AnaisCheval AnaisCheval self-assigned this Jul 14, 2025
Copy link
Copy Markdown

@AnaisCheval AnaisCheval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix !

@Mark2000 Mark2000 merged commit 90701be into develop Jul 14, 2025
8 of 10 checks passed
@Mark2000 Mark2000 deleted the bugfix/294-multiple-rewarders branch July 14, 2025 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Multiple rewarders of the same time overwrite each others settings

3 participants