[#294] Fix multiple rewarders of same type#295
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
Fixes a bug where multiple rewarders of the same type would overwrite each other’s settings by changing the way data_store_kwargs are passed and handled.
- Switched
ComposedDataStore’sdata_store_kwargsparameter from a dict to a list and zipped it withdata_store_types. - Updated
create_data_storeto pass a list of kwargs instead of a dict. - Documented the fix in the release notes.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/bsk_rl/data/composition.py | Changed data_store_kwargs to a list, updated constructor and call site. |
| docs/source/release_notes.rst | Added an entry about fixing multiple-rewarder overwrite issues. |
ad65899 to
a518f90
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #294
Fixes bug.
Type of change
How should this pull request be reviewed?
How Has This Been Tested?
Fixes bug.
Future Work
None.
Checklist