Merged
Conversation
d88c656 to
4195ae0
Compare
e4eca22 to
615779d
Compare
6f3e0ac to
bd526f6
Compare
bd526f6 to
229e226
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new enforce_range_on_chief option to the MaxRangeDynModel that causes the chief satellite to also be terminated if a deputy satellite violates the maximum range constraint. Additionally, it fixes a simulation initialization issue where bad behavior occurred when a satellite died at t=0.
- Adds bidirectional range enforcement capability to
MaxRangeDynModel - Fixes simulator initialization by replacing
ConfigureStopTimeandExecuteSimulationwithStepUntilStop - Updates tests to verify both chief and deputy termination behavior under range violations
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/bsk_rl/sim/dyn/relative_motion.py |
Adds enforce_range_on_chief parameter and implements dynamic method binding for chief termination |
src/bsk_rl/sim/simulator.py |
Fixes initialization issue by changing simulation execution method |
tests/integration/sim/test_int_dynamics.py |
Adds parametrized tests to verify chief termination behavior |
docs/source/release_notes.rst |
Documents the new bidirectional range enforcement feature |
Comments suppressed due to low confidence (1)
src/bsk_rl/sim/dyn/relative_motion.py:190
- The parameter name 'self' is confusing as a default argument when 'self' is already the method's first parameter. Consider renaming to 'deputy_dynamics=self' or similar to clarify this refers to the deputy's dynamics object.
def range_valid(self, deputy=self):
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #298
Closes #300
Adds
enforce_range_on_chiefoption toMaxRangeDynModelto cause the chief to also be terminated if the deputy dies.Also fixes an issue exposed in tests where bad behavior would happen if a satellite died at t=0.
Type of change
How should this pull request be reviewed?
How Has This Been Tested?
Updated tests.
Future Work
None.
Checklist