Merged
Conversation
0745f3e to
cbfd636
Compare
Contributor
Author
|
TODO
|
cbfd636 to
83938e8
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes performance of AEOS environments for high request counts through various efficiency improvements.
- Simplified data storage from lists to sets for UniqueImageData to improve performance
- Optimized cross product calculations by replacing np.cross with manual computation
- Added time-based filtering for access window calculations to reduce computation load
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/bsk_rl/data/unique_image_data.py | Convert lists to sets for target tracking and simplify reward calculation logic |
| src/bsk_rl/sats/access_satellite.py | Add time-based filtering, optimize buffer management, and improve opportunity calculation |
| src/bsk_rl/utils/orbital.py | Replace np.cross with manual cross product calculation for performance |
| src/bsk_rl/obs/observations.py | Cache observation space properties to avoid recomputation |
| src/bsk_rl/gym.py | Replace sample() with low bounds for zero observations and optimize logging |
| src/bsk_rl/scene/targets.py | Remove hash method from Target class |
| tests/unittest/data/test_data.py | Update tests to match new set-based data structure |
| tests/unittest/sats/test_access_satellite.py | Update tests for new parameters and simplified buffer management |
| docs/source/release_notes.rst | Document performance optimization changes |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
32c1f0e to
c1832ea
Compare
Contributor
Author
|
Hmm @LorenzzoQM are these changes breaking the cloud environment in the doc build? |
Contributor
|
@Mark2000 The issue is that both cloud examples inherit from the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #309
Closes #235
Various changes for performance improvements. See commit messages for details.
Type of change
How should this pull request be reviewed?
How Has This Been Tested?
Updated tests. Integrated tests remain the same.
Checklist