Skip to content

Feature/access improvements#301

Merged
Mark2000 merged 13 commits intodevelopfrom
feature/access-improvements
Oct 16, 2025
Merged

Feature/access improvements#301
Mark2000 merged 13 commits intodevelopfrom
feature/access-improvements

Conversation

@Mark2000
Copy link
Copy Markdown
Contributor

@Mark2000 Mark2000 commented Aug 1, 2025

Description

Closes #309
Closes #235

Various changes for performance improvements. See commit messages for details.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How should this pull request be reviewed?

  • By commit
  • All changes at once

How Has This Been Tested?

Updated tests. Integrated tests remain the same.

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation and release notes
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@Mark2000 Mark2000 changed the base branch from develop to feature/199-one-way-comm August 1, 2025 04:03
Base automatically changed from feature/199-one-way-comm to develop August 11, 2025 18:49
@Mark2000 Mark2000 force-pushed the feature/access-improvements branch 2 times, most recently from 0745f3e to cbfd636 Compare September 15, 2025 14:56
@Mark2000
Copy link
Copy Markdown
Contributor Author

Mark2000 commented Sep 15, 2025

TODO

  • Reward issue in set commit
  • Documentation
  • Resolve tests

@Mark2000 Mark2000 force-pushed the feature/access-improvements branch from cbfd636 to 83938e8 Compare September 15, 2025 16:05
@Mark2000 Mark2000 marked this pull request as ready for review September 15, 2025 16:06
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR optimizes performance of AEOS environments for high request counts through various efficiency improvements.

  • Simplified data storage from lists to sets for UniqueImageData to improve performance
  • Optimized cross product calculations by replacing np.cross with manual computation
  • Added time-based filtering for access window calculations to reduce computation load

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
src/bsk_rl/data/unique_image_data.py Convert lists to sets for target tracking and simplify reward calculation logic
src/bsk_rl/sats/access_satellite.py Add time-based filtering, optimize buffer management, and improve opportunity calculation
src/bsk_rl/utils/orbital.py Replace np.cross with manual cross product calculation for performance
src/bsk_rl/obs/observations.py Cache observation space properties to avoid recomputation
src/bsk_rl/gym.py Replace sample() with low bounds for zero observations and optimize logging
src/bsk_rl/scene/targets.py Remove hash method from Target class
tests/unittest/data/test_data.py Update tests to match new set-based data structure
tests/unittest/sats/test_access_satellite.py Update tests for new parameters and simplified buffer management
docs/source/release_notes.rst Document performance optimization changes

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Mark2000 Mark2000 force-pushed the feature/access-improvements branch from 32c1f0e to c1832ea Compare September 15, 2025 16:10
@Mark2000
Copy link
Copy Markdown
Contributor Author

Hmm @LorenzzoQM are these changes breaking the cloud environment in the doc build?

@LorenzzoQM
Copy link
Copy Markdown
Contributor

@Mark2000 The issue is that both cloud examples inherit from the DataStore and UniqueImageStore, but the compare_log_states is implemented in the old way (as it was before the "Refactor to use single buffer in EOS envs" commit). I don't think it will break anything else, but I will double-check it

@Mark2000 Mark2000 mentioned this pull request Sep 30, 2025
16 tasks
@Mark2000 Mark2000 merged commit 33dcd34 into develop Oct 16, 2025
5 checks passed
@Mark2000 Mark2000 deleted the feature/access-improvements branch October 16, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve the speed of EOS environments Number of buffers should be automatically set

3 participants