Merged
Conversation
1f1d804 to
2ce0833
Compare
56a6efe to
7e7ecd7
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR transitions BSK-RL from building Basilisk from source to using pre-built Basilisk wheels distributed on PyPI. The change simplifies the build process by adding bsk==2.8.9 as a direct dependency and updating CI/CD workflows to use a streamlined build action.
- Added
bsk==2.8.9as a dependency inpyproject.toml - Replaced custom Basilisk wheel retrieval with standard PyPI installation
- Simplified CI/CD workflows by replacing complex build action with straightforward dependency installation
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Adds bsk dependency to enable PyPI-based installation |
| docs/source/release_notes.rst | Documents the dependency addition and CI/CD workflow updates |
| .github/workflows/pull_request_closed.yml | Removes trailing whitespace |
| .github/workflows/documentation.yml | Updates to use new build action and removes whitespace |
| .github/workflows/commit_checks.yml | Standardizes quotes and updates to use new build action |
| .github/actions/install-bsk-rl/action.yml | Removes complex action that downloaded Basilisk artifacts |
| .github/actions/build/action.yml | Adds simplified build action using standard pip installation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
LorenzzoQM
reviewed
Sep 12, 2025
Renames the "install-bsk-rl" composite action to "build" for consistency with the Basilisk CI/CD pipeline.
We dont need to check the versions since its now specified in the pyproject.toml file.
12b6578 to
f4307e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR switches bsk-rl from using basilisk built from source to basilisk wheels that are published.
Type of change
How should this pull request be reviewed?
How Has This Been Tested?
The GitHub Actions should succeed if everything is good.
Future Work
N/A
Checklist
Closes #308