Skip to content

Use bsk from PyPi for builds#307

Merged
ReeceHumphreys merged 6 commits intodevelopfrom
feature/use-pypi-bsk
Sep 14, 2025
Merged

Use bsk from PyPi for builds#307
ReeceHumphreys merged 6 commits intodevelopfrom
feature/use-pypi-bsk

Conversation

@ReeceHumphreys
Copy link
Copy Markdown
Contributor

@ReeceHumphreys ReeceHumphreys commented Sep 12, 2025

Description

This PR switches bsk-rl from using basilisk built from source to basilisk wheels that are published.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How should this pull request be reviewed?

  • By commit
  • All changes at once

How Has This Been Tested?

The GitHub Actions should succeed if everything is good.

Future Work

N/A

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation and release notes
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Closes #308

@ReeceHumphreys ReeceHumphreys requested review from Mark2000 and Copilot and removed request for Copilot September 12, 2025 22:00
@ReeceHumphreys ReeceHumphreys self-assigned this Sep 12, 2025
@ReeceHumphreys ReeceHumphreys added enhancement New feature or request infrastructure Testing, documentation, and CI system labels Sep 12, 2025
@ReeceHumphreys ReeceHumphreys force-pushed the feature/use-pypi-bsk branch 2 times, most recently from 56a6efe to 7e7ecd7 Compare September 12, 2025 22:09
Copilot AI review requested due to automatic review settings September 12, 2025 22:09
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR transitions BSK-RL from building Basilisk from source to using pre-built Basilisk wheels distributed on PyPI. The change simplifies the build process by adding bsk==2.8.9 as a direct dependency and updating CI/CD workflows to use a streamlined build action.

  • Added bsk==2.8.9 as a dependency in pyproject.toml
  • Replaced custom Basilisk wheel retrieval with standard PyPI installation
  • Simplified CI/CD workflows by replacing complex build action with straightforward dependency installation

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
pyproject.toml Adds bsk dependency to enable PyPI-based installation
docs/source/release_notes.rst Documents the dependency addition and CI/CD workflow updates
.github/workflows/pull_request_closed.yml Removes trailing whitespace
.github/workflows/documentation.yml Updates to use new build action and removes whitespace
.github/workflows/commit_checks.yml Standardizes quotes and updates to use new build action
.github/actions/install-bsk-rl/action.yml Removes complex action that downloaded Basilisk artifacts
.github/actions/build/action.yml Adds simplified build action using standard pip installation

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Renames the "install-bsk-rl" composite action to "build" for
consistency with the Basilisk CI/CD pipeline.
We dont need to check the versions since its now specified in the
pyproject.toml file.
Copy link
Copy Markdown
Contributor

@Mark2000 Mark2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

@ReeceHumphreys ReeceHumphreys merged commit ca18332 into develop Sep 14, 2025
5 checks passed
@ReeceHumphreys ReeceHumphreys deleted the feature/use-pypi-bsk branch September 14, 2025 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request infrastructure Testing, documentation, and CI system

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use bsk wheel from PyPi

4 participants