Merged
Conversation
bced97c to
7f0ff88
Compare
7f60d04 to
46ae5e6
Compare
Contributor
Author
|
Should wait to merge until Vizard 2.3.1 release and AVSLab/basilisk#1142 is merged in BSK. |
Contributor
Author
|
@LorenzzoQM I think this should be ready for a quick look whenever you get a chance |
6b1403f to
8137e52
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades visualization capabilities for ground locations in Vizard, introducing a simplified Earth shader option and updating location visualization methods. The changes leverage Vizard 2.3.1 location features to reduce output file sizes and improve ground location visibility.
Key Changes:
- Added
use_simple_earthparameter to enable a lower-detail Earth shader for better ground location viewing - Migrated from direct location property manipulation to
vizSupport.changeLocation()API calls - Replaced
conditionFunctionwithconditionTimefor event conditions to improve performance
Reviewed Changes
Copilot reviewed 10 out of 12 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/bsk_rl/sim/simulator.py | Added simple Earth shader support, improved file path handling for Vizard saves, and updated event condition handling |
| src/bsk_rl/scene/targets.py | Added marker scaling based on target priority |
| src/bsk_rl/sats/satellite.py | Updated event condition from function to time-based |
| src/bsk_rl/gym.py | Updated documentation and fixed vizard_settings warning logic |
| src/bsk_rl/data/unique_image_data.py | Migrated to changeLocation API for target color updates |
| src/bsk_rl/data/rso_inspection.py | Refactored point color updates to use changeLocation API and moved logic to GlobalReward class |
| tests/unittest/sim/test_simulator.py | Removed eventList assertions from delete_event test |
| examples/fault_environment.ipynb | Updated event creation syntax and removed blank lines |
| docs/source/release_notes.rst | Added release note about Vizard 2.3.1 location usage |
| docs/source/index.rst | Added capability showcase videos |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
8137e52 to
4c9268c
Compare
4c9268c to
b4b6ef0
Compare
LorenzzoQM
reviewed
Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #316
Closes #293
Please include a summary, motivation, and context of the changes and the related issue.
Type of change
How should this pull request be reviewed?
How Has This Been Tested?
Please describe how tests have been updated to verify your changes.
Future Work
What future tasks are needed, if any?
Checklist