Skip to content

Feature/viz location upgrade#317

Merged
Mark2000 merged 8 commits intodevelopfrom
feature/viz-location-upgrade
Nov 3, 2025
Merged

Feature/viz location upgrade#317
Mark2000 merged 8 commits intodevelopfrom
feature/viz-location-upgrade

Conversation

@Mark2000
Copy link
Copy Markdown
Contributor

@Mark2000 Mark2000 commented Oct 10, 2025

Description

Closes #316
Closes #293

Please include a summary, motivation, and context of the changes and the related issue.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How should this pull request be reviewed?

  • By commit
  • All changes at once

How Has This Been Tested?

Please describe how tests have been updated to verify your changes.

Future Work

What future tasks are needed, if any?

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation and release notes
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@Mark2000 Mark2000 force-pushed the feature/viz-location-upgrade branch 2 times, most recently from bced97c to 7f0ff88 Compare October 10, 2025 21:26
@Mark2000 Mark2000 force-pushed the feature/viz-location-upgrade branch from 7f60d04 to 46ae5e6 Compare October 16, 2025 17:46
@Mark2000
Copy link
Copy Markdown
Contributor Author

Should wait to merge until Vizard 2.3.1 release and AVSLab/basilisk#1142 is merged in BSK.

@Mark2000
Copy link
Copy Markdown
Contributor Author

@LorenzzoQM I think this should be ready for a quick look whenever you get a chance

@Mark2000 Mark2000 force-pushed the feature/viz-location-upgrade branch from 6b1403f to 8137e52 Compare October 20, 2025 21:59
@Mark2000 Mark2000 marked this pull request as ready for review October 20, 2025 22:41
Copilot AI review requested due to automatic review settings October 20, 2025 22:41
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades visualization capabilities for ground locations in Vizard, introducing a simplified Earth shader option and updating location visualization methods. The changes leverage Vizard 2.3.1 location features to reduce output file sizes and improve ground location visibility.

Key Changes:

  • Added use_simple_earth parameter to enable a lower-detail Earth shader for better ground location viewing
  • Migrated from direct location property manipulation to vizSupport.changeLocation() API calls
  • Replaced conditionFunction with conditionTime for event conditions to improve performance

Reviewed Changes

Copilot reviewed 10 out of 12 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
src/bsk_rl/sim/simulator.py Added simple Earth shader support, improved file path handling for Vizard saves, and updated event condition handling
src/bsk_rl/scene/targets.py Added marker scaling based on target priority
src/bsk_rl/sats/satellite.py Updated event condition from function to time-based
src/bsk_rl/gym.py Updated documentation and fixed vizard_settings warning logic
src/bsk_rl/data/unique_image_data.py Migrated to changeLocation API for target color updates
src/bsk_rl/data/rso_inspection.py Refactored point color updates to use changeLocation API and moved logic to GlobalReward class
tests/unittest/sim/test_simulator.py Removed eventList assertions from delete_event test
examples/fault_environment.ipynb Updated event creation syntax and removed blank lines
docs/source/release_notes.rst Added release note about Vizard 2.3.1 location usage
docs/source/index.rst Added capability showcase videos

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Mark2000 Mark2000 force-pushed the feature/viz-location-upgrade branch from 8137e52 to 4c9268c Compare October 20, 2025 23:07
@Mark2000 Mark2000 requested a review from LorenzzoQM October 21, 2025 14:22
@Mark2000 Mark2000 force-pushed the feature/viz-location-upgrade branch from 4c9268c to b4b6ef0 Compare October 21, 2025 14:54
Copy link
Copy Markdown
Contributor

@LorenzzoQM LorenzzoQM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Mark2000 Mark2000 merged commit 818c593 into develop Nov 3, 2025
7 checks passed
@Mark2000 Mark2000 deleted the feature/viz-location-upgrade branch November 3, 2025 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade vizard locations for vizard 2.3.1 Scale targets in EOS vizard

3 participants