Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces configurable collision checking rates and updates stop condition behavior in Basilisk simulations. The key improvement allows collision detection to run at a different frequency than the main simulation rate, which is beneficial when spacecraft motion is slow relative to the simulation timestep.
Key changes:
- Added
conjunction_check_rateparameter tosetup_conjunctions()with optional configuration - Updated
ConfigureStopTimecalls to useStopCondition=">="for more reliable stop behavior - Set
exactRateMatch=Falsefor conjunction events to allow flexible timing
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/bsk_rl/sim/dyn/relative_motion.py | Added configurable conjunction check rate with optional parameter defaulting to sim rate |
| src/bsk_rl/sim/simulator.py | Updated stop time configuration to use ">=" stop condition |
| tests/unittest/sim/test_simulator.py | Updated test assertion to verify new stop condition parameter |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
d1b8626 to
70f29d2
Compare
dhutererprats
left a comment
There was a problem hiding this comment.
Looks good to me.
One thing thought is that I dont see where you are using the exactRateMatch flag yet... or is this something you plan on further implementing later?
dhutererprats
left a comment
There was a problem hiding this comment.
Helpful new feature!
Description
Allows for collisions to be checked for at a different rate than the sim. Helpful if you know motion is slow relative to the sim rate.
Also uses the new basilisk stop condition for better behavior.
Type of change
How should this pull request be reviewed?
Future Work
Do other things need configurable rates?
Checklist