Skip to content

[#328] Attitude control action#329

Merged
Mark2000 merged 1 commit intodevelopfrom
feature/attitude-control
Jan 5, 2026
Merged

[#328] Attitude control action#329
Mark2000 merged 1 commit intodevelopfrom
feature/attitude-control

Conversation

@Mark2000
Copy link
Contributor

@Mark2000 Mark2000 commented Jan 3, 2026

Description

Closes #328
Closes #234

Adds action and FSW for continuous attitude control

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How should this pull request be reviewed?

  • By commit
  • All changes at once

How Has This Been Tested?

Added integrated test.

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation and release notes
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Copilot AI review requested due to automatic review settings January 3, 2026 00:38
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds support for continuous attitude control by introducing a new AttitudeSetpoint action that allows agents to set the satellite's inertial attitude using Modified Rodrigues Parameters (MRPs).

Key changes:

  • Adds AttitudeSetpoint continuous action class with 3-dimensional action space for MRP control
  • Moves TrackingErrorTask from BasicFSWModel to base FSWModel to enable attitude control for all FSW models
  • Adds action_attitude_mrp method to FSWModel for setting attitude references
  • Includes integration test validating attitude control with both basic and full dynamics models

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
tests/integration/act/test_int_actions_continuous.py Adds TestAttitudeSetpoint class with parametrized test validating attitude control functionality
src/bsk_rl/sim/fsw/base.py Moves TrackingErrorTask to base FSWModel class and adds action_attitude_mrp method for attitude commands
src/bsk_rl/act/continuous_actions.py Implements AttitudeSetpoint action class with 3D MRP action space and control period parameter
src/bsk_rl/act/init.py Exports new AttitudeSetpoint action and previously missing NadirPoint action
docs/source/release_notes.rst Documents the new attitude control action in release notes

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Mark2000 Mark2000 force-pushed the feature/attitude-control branch from 125e2c6 to 0571cfc Compare January 3, 2026 03:03
@Mark2000 Mark2000 merged commit 7eb6d1d into develop Jan 5, 2026
7 checks passed
@Mark2000 Mark2000 deleted the feature/attitude-control branch January 5, 2026 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Continuous action for attitude control Fine-Grained Attitude Control in bsk-rl for Satellite Imaging

2 participants