Conversation
There was a problem hiding this comment.
Pull request overview
This pull request adds support for continuous attitude control by introducing a new AttitudeSetpoint action that allows agents to set the satellite's inertial attitude using Modified Rodrigues Parameters (MRPs).
Key changes:
- Adds
AttitudeSetpointcontinuous action class with 3-dimensional action space for MRP control - Moves
TrackingErrorTaskfromBasicFSWModelto baseFSWModelto enable attitude control for all FSW models - Adds
action_attitude_mrpmethod toFSWModelfor setting attitude references - Includes integration test validating attitude control with both basic and full dynamics models
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/integration/act/test_int_actions_continuous.py | Adds TestAttitudeSetpoint class with parametrized test validating attitude control functionality |
| src/bsk_rl/sim/fsw/base.py | Moves TrackingErrorTask to base FSWModel class and adds action_attitude_mrp method for attitude commands |
| src/bsk_rl/act/continuous_actions.py | Implements AttitudeSetpoint action class with 3D MRP action space and control period parameter |
| src/bsk_rl/act/init.py | Exports new AttitudeSetpoint action and previously missing NadirPoint action |
| docs/source/release_notes.rst | Documents the new attitude control action in release notes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
125e2c6 to
0571cfc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #328
Closes #234
Adds action and FSW for continuous attitude control
Type of change
How should this pull request be reviewed?
How Has This Been Tested?
Added integrated test.
Checklist