Update illumination factor convention#332
Merged
dhutererprats merged 2 commits intodevelopfrom Feb 25, 2026
Merged
Conversation
cadd7a1 to
5b2c423
Compare
Mark2000
approved these changes
Feb 24, 2026
Contributor
Mark2000
left a comment
There was a problem hiding this comment.
Looks good! Could you add a note in the release notes alerting people to the change?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #
This PR standardizes naming from shadow-based terms to illumination-based terms in the RSO inspection/eclipsing paths.
Summary
min_illumination_factorilluminationFactorType of change
How should this pull request be reviewed?
How Has This Been Tested?
git grep -n -E "shadowFactor|min_shadow_factor|shadow_factor" src/bsk_rl tests/unittest(no matches).venv/bin/python -m py_compile src/bsk_rl/scene/rso_points.py src/bsk_rl/sim/dyn/rso_inspection.py src/bsk_rl/utils/orbital.pymin_illumination_factorandilluminationFactor).Note: full pytest execution in this sandbox is still blocked by local pandas binary policy.
Future Work
N/A
Checklist