Skip to content

Bug/fix target angle rate#334

Merged
LorenzzoQM merged 2 commits intodevelopfrom
bug/fix_target_angle_rate
Mar 9, 2026
Merged

Bug/fix target angle rate#334
LorenzzoQM merged 2 commits intodevelopfrom
bug/fix_target_angle_rate

Conversation

@LorenzzoQM
Copy link
Contributor

Description

Closes #306

Target angle rate used v_BN_P instead of r_BN_P.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How should this pull request be reviewed?

  • By commit
  • All changes at once

How Has This Been Tested?

Pytest tests passed.

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation and release notes
  • My changes generate no new warnings
  • [] I have added tests that prove my fix is effective or that my feature works

@LorenzzoQM LorenzzoQM requested a review from Mark2000 March 9, 2026 16:35
@LorenzzoQM LorenzzoQM self-assigned this Mar 9, 2026
Copilot AI review requested due to automatic review settings March 9, 2026 16:35
Copy link
Contributor

@Mark2000 Mark2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple fix, thanks!

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes an error in the target angle rate observation where the spacecraft position vector was incorrectly taken from the velocity state, aligning the implementation with the intended target-rate computation (Issue #306).

Changes:

  • Update _target_angle_rate to use sat.dynamics.r_BN_P instead of sat.dynamics.v_BN_P for r_BN_P.
  • Document the fix in the Development release notes.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/bsk_rl/obs/observations.py Corrects the state vector used in _target_angle_rate computation.
docs/source/release_notes.rst Adds an entry describing the target angle rate observation fix.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@LorenzzoQM LorenzzoQM merged commit 5697f0e into develop Mar 9, 2026
40 of 46 checks passed
@LorenzzoQM LorenzzoQM deleted the bug/fix_target_angle_rate branch March 9, 2026 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Target angle rate observation uses velocity instead of position vector

3 participants