Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes an error in the target angle rate observation where the spacecraft position vector was incorrectly taken from the velocity state, aligning the implementation with the intended target-rate computation (Issue #306).
Changes:
- Update
_target_angle_rateto usesat.dynamics.r_BN_Pinstead ofsat.dynamics.v_BN_Pforr_BN_P. - Document the fix in the Development release notes.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/bsk_rl/obs/observations.py |
Corrects the state vector used in _target_angle_rate computation. |
docs/source/release_notes.rst |
Adds an entry describing the target angle rate observation fix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #306
Target angle rate used
v_BN_Pinstead ofr_BN_P.Type of change
How should this pull request be reviewed?
How Has This Been Tested?
Pytest tests passed.
Checklist