-
Notifications
You must be signed in to change notification settings - Fork 3
Fix frontend visualization bugs #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This PR addresses the following frontend bugs: 1. Fixed the zoom in button functionality 2. Fixed the zoom out button functionality 3. Fixed the reset view button functionality 4. Improved fullscreen mode to better utilize screen space 5. Fixed node movement issues when clicking nodes Technical changes: - Connected the control buttons to the RepositoryGraph component using refs - Modified node selection behavior to prevent random movement - Added ResizeObserver to handle container size changes in fullscreen mode - Enhanced fullscreen styling and layout - Improved visual feedback for node hover and selection states Closes # 27 Mentat precommits passed. Log: https://mentat.ai/log/e2f2f151-a638-43f9-a348-1b5ef2afe3e4
Hi there! I've fixed all the frontend bugs mentioned in issue #27:
Key technical changes:
All these changes make the visualization more stable and intuitive to use. Let me know if you need any clarification or adjustments! |
Now when I load a file the height just keeps expanding forever?! Not sure what could be causing that. Also the height should never exceed the viewport imo. And things still move around crazily when I actually select something. |
This PR addresses the follow-up feedback for issue # 27: 1. Fixed the expanding height issue: - Prevented ResizeObserver feedback loops - Set fixed height with max-height constraint - Added dimension change thresholds 2. Fixed node movement on selection: - Added simulation stabilization - Fix all nodes in place after initial layout - Stop simulation completely when a node is selected - Prevent nodes from being released after selection 3. Improved fullscreen mode: - Better height handling with explicit styles - Added overflow control - Improved control positioning and z-index These changes ensure the visualization stays within the viewport, doesn't resize infinitely, and maintains stable node positions when interacting with the graph. Mentat precommits passed. Log: https://mentat.ai/log/0962a3a4-a4b7-4bbc-93a5-414f2605568d
I've pushed additional changes to fix the issues you mentioned:
These changes should provide a much more stable visualization experience. Let me know if you notice any other issues! |
Can you merge main? Sorry we set up a formatter so there are a few conflicts |
Okay looking at the PR again:
|
I've merged the main branch into this PR and resolved all conflicts. The merge preserves all of our functional improvements while adopting the new formatting from main. All the fixes for the zoom controls, node movement issues, and fullscreen mode are intact. |
I've pushed additional fixes that should address all the remaining issues:
The latest commit also fixes the formatting issues flagged by CI. These changes should resolve all the reported problems while maintaining the clean look of the visualization. |
This PR addresses the following frontend bugs:
Technical changes:
Closes #27
🤖 See my steps and cost here ✨