Skip to content

chore(deps): drop Grpc.AspNetCore — use Google.Protobuf for ProtoBuf-only storage - #68

Merged
kirill-abblix merged 1 commit into
masterfrom
feature/grpc-aspnetcore-to-protobuf-runtime
Apr 29, 2026
Merged

chore(deps): drop Grpc.AspNetCore — use Google.Protobuf for ProtoBuf-only storage#68
kirill-abblix merged 1 commit into
masterfrom
feature/grpc-aspnetcore-to-protobuf-runtime

Conversation

@kirill-abblix

@kirill-abblix kirill-abblix commented Apr 29, 2026

Copy link
Copy Markdown
Member

Summary

  • Abblix.Oidc.Server uses ProtoBuf only for Redis storage (Features/Storages/Proto/*.proto with GrpcServices="None") and never hosts gRPC endpointsAddGrpc / MapGrpcService / Grpc.AspNetCore.Server are not present in the codebase.
  • The Grpc.AspNetCore umbrella is replaced with the runtime-only Google.Protobuf 3.34.1 (matches the Abblix.Utils version). Grpc.Tools 2.78.0 stays as the build-time driver for protoc / MSBuild.
  • Aligns with the canonical pattern in Docs/wiki/protobuf-redis-session-storage.md § MSBuild integration (updated today).
  • All <Protobuf> includes already had GrpcServices="None" — no further change needed.

Cross-repo: parallel PRs Abblix/AuthenticationService#80 and Abblix/Kezio#161 apply the same approach.

Abblix.Oidc.Server library uses ProtoBuf only for Redis storage
serialization (Features/Storages/Proto/*.proto with GrpcServices="None")
and never hosts gRPC endpoints — no AddGrpc, MapGrpcService or
Grpc.AspNetCore.Server references anywhere in the codebase.

Replaces the Grpc.AspNetCore umbrella with the runtime-only
Google.Protobuf 3.34.1 (matches Abblix.Utils version). Grpc.Tools
2.78.0 stays as the build-time protoc/MSBuild driver.

Aligns the project with the canonical pattern in
Docs/wiki/protobuf-redis-session-storage.md § MSBuild-интеграция.
@kirill-abblix
kirill-abblix force-pushed the feature/grpc-aspnetcore-to-protobuf-runtime branch from 66040ad to ddf38b5 Compare April 29, 2026 08:50
@sonarqubecloud

Copy link
Copy Markdown

@kirill-abblix
kirill-abblix merged commit 4eef79f into master Apr 29, 2026
4 checks passed
@kirill-abblix
kirill-abblix deleted the feature/grpc-aspnetcore-to-protobuf-runtime branch April 29, 2026 08:54
@kirill-abblix

Copy link
Copy Markdown
Member Author

Post-merge note (2026-04-29): rolled back from master.

This PR was created against master by mistake — it should have targeted develop, like every other feature/refactor PR in this repo. After merge I caught the Git Flow violation and reset master to the pre-session tip (71dd981) via git push --force-with-lease.

The change itself (Grpc.AspNetCore → Google.Protobuf in Abblix.Oidc.Server.csproj) survives on develop through the master → develop back-merge in e7b9d65. It will re-land on master through the next release branch, the way the repo's Git Flow expects.

Net state:

Codified feature → develop rule in this repo's CLAUDE.md and in cross-repo memory (feedback-default-base-branch-develop.md) so the same drift doesn't recur.

kirill-abblix added a commit that referenced this pull request Jul 4, 2026
Abblix.Oidc.Server library uses ProtoBuf only for Redis storage
serialization (Features/Storages/Proto/*.proto with GrpcServices="None")
and never hosts gRPC endpoints — no AddGrpc, MapGrpcService or
Grpc.AspNetCore.Server references anywhere in the codebase.

Replaces the Grpc.AspNetCore umbrella with the runtime-only
Google.Protobuf 3.34.1 (matches Abblix.Utils version). Grpc.Tools
2.78.0 stays as the build-time protoc/MSBuild driver.

Aligns the project with the canonical pattern in
Docs/wiki/protobuf-redis-session-storage.md § MSBuild-интеграция.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant