feat(windows): add Windows support backed by PlayFab#230
Open
RealMeeseeks wants to merge 5 commits into
Open
Conversation
Google's Play Games Services quality checklist (item 6.1) requires a cover image when saving a game. The saveGame flow previously did not expose any way to set one. Add optional `coverImage` (image bytes), `description` and `playedTime` parameters to `SaveGame.saveGame`, threaded through the federated platform interface and the method channel. On Android these are applied via `SnapshotMetadataChange.Builder` (`setCoverImage` decodes the bytes to a Bitmap, plus `setDescription` / `setPlayedTimeMillis`). They are ignored on iOS/macOS (Game Center has no snapshot metadata equivalent). All new parameters are optional, so existing callers are unaffected. Also fixes the previous Android bug where the unique name was passed as the snapshot description; the description is now only set when provided. Bumps both packages to 5.1.0 and updates the example app and docs/save_load_game.md. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Windows has no native equivalent of Game Center or Google Play Games, so this adds a pure-Dart federated implementation backed by the Microsoft PlayFab REST API, registered for the windows platform via dartPluginClass. - New GamesServicesPlayFab implementation (auth via LoginWithCustomID with a persisted device GUID, leaderboards via player statistics, achievements via Title Data definitions + User Data progress, saved games via entity files). - Add non-breaking GamesServices/GameAuth.initialize(playFabTitleId: ...) and a no-op default on the platform interface; add Device.isPlatformWindows. - Add http + shared_preferences deps and the windows runner to the example. - Unit tests (mocked http.Client) covering the REST mappings. - Docs (docs/windows_playfab.md + README), CHANGELOGs, versions -> 5.2.0. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The PR Checks workflow installed Flutter 3.7.3, which cannot satisfy the packages' `sdk: ^3.12.0` / `flutter: ">=3.44.0"` constraints, so `flutter pub get` failed before Danger ran (the step exited 1 with no Danger comment posted). - Install a compatible Flutter (3.44.1 stable) via subosito/flutter-action, and bump actions/checkout to v4. - Run `flutter analyze` inside each package instead of the repo root (which has no pubspec.yaml and always errored). - Resolve example dependencies too. - Soften the >1000-line PR size rule from fail to warn; a new-platform integration legitimately exceeds it. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The Danger step used a custom `DANGER_GITHUB_API_TOKEN` repo secret that GitHub rejected as "Bad credentials" (401), so Danger could not fetch the pull request and the step failed. Switch to the run's built-in `secrets.GITHUB_TOKEN` and grant the job `pull-requests: write` / `contents: read`. This removes the dependency on a manually-maintained PAT secret. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
`flutter analyze` (Dart 3.12.1 lints) reported 4 issues: - prefer_initializing_formals in GamesServicesPlayFab: renamed the injected constructor parameter to `playFabClient` (a private field can't be a named initializing formal). - use_null_aware_elements (x3) in PlayFabClient: replaced `if (x != null) "Key": x` map entries with the null-aware `"Key": ?x` form in getPlayerStatistics and updateUserData. Also silence the pre-existing monorepo `invalid_dependency` (path dependency) warning via analysis_options, and drop a now-redundant test import/cast. Verified clean with `flutter analyze` on both packages and all tests passing under Flutter 3.44.1. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
theLee3
reviewed
Jun 17, 2026
Collaborator
There was a problem hiding this comment.
I am in the process of reviewing the full addition as well as setting up PlayFab to test. However, I have a couple of initial thoughts after a cursory reading of the changes.
As the package is already structured as a federated plugin, would it not be better to add the PlayFab functionality under an endorsed federated games_services_windows package? This would remove the Windows specific implementation from the games_services package where devs would have unnecessary knowledge of the public class and methods used, as well as removing the base package's dependency on http and shared_preferences.
Also, is it possible to be less opinionated on the ID generation and use of shared_preferences? Is this something that we can leave to the developer and simply provide a means of using the tokens to communicate with PlayFab? This would allow cross device account usage as well as the use of different auth services.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Windows support to games_services via a pure-Dart implementation backed by the Microsoft PlayFab REST API (registered for the windows platform via dartPluginClass).
What
GamesServicesPlayFabimplementing the full platform interface:LoginWithCustomIDwith a device GUID persisted in shared_preferencesUpdatePlayerStatistics,GetLeaderboard/AroundPlayer/Friend)GamesServices.initialize(playFabTitleId: ...)(no-op elsewhere) +Device.isPlatformWindowsdocs/windows_playfab.md+ README); versions -> 5.2.0Verification
dart analyzeclean; 12 unit tests passflutter build windows, and a real end-to-end test needs a live PlayFab title (see docs for Game Manager setup).