Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#246: Implement basics of ParitioningReader #323

Merged
merged 63 commits into from
Mar 3, 2025

Conversation

benedeki
Copy link
Contributor

@benedeki benedeki commented Mar 1, 2025

  • PartitioningReader methods to retrieve checkpoints and additional data
  • AdditionalDataItemDTO value filed cannot be optional anymore
  • Agent uses the shared ApiPath constants
  • Several endpoints made visible in Swagger documentation

Closes #246

Release notes:

  • PartitioningReader implemented to return the checkpoints (requested and returned in a paginated form) and additional data.

benedeki and others added 30 commits October 31, 2024 01:23
* created new module Info
* the new modul added to JaCoco and CI routines
* JaCoCo exclusion for model
* created Provider to query the data from server
* support for Future, IO, and ZIO based providers
* work in progress
Copy link

github-actions bot commented Mar 1, 2025

JaCoCo model module code coverage report - scala 2.13.11

Overall Project 56.51% -0.48% 🍏
Files changed 60%

File Coverage
AdditionalDataItemDTO.scala 100% -26.67%

Copy link

github-actions bot commented Mar 1, 2025

JaCoCo agent module code coverage report - scala 2.13.11

Overall Project 78.44% -2.19% 🍏
Files changed 75.69%

File Coverage
AtumContext.scala 91.79% 🍏
CapturingDispatcher.scala 87.43% 🍏
HttpDispatcher.scala 37.85% -9.67%

Copy link

github-actions bot commented Mar 1, 2025

JaCoCo reader module code coverage report - scala 2.13.11

Overall Project 95.16% -21.07% 🍏
Files changed 57.04%

File Coverage
PartitioningReader.scala 100% -78.71%

Copy link

github-actions bot commented Mar 1, 2025

JaCoCo server module code coverage report - scala 2.13.11

Overall Project 68.39% 🍏
File Coverage
AdditionalDataItemFromDB.scala 100% 🍏
PartitioningControllerImpl.scala 91.67% 🍏

salamonpavel
salamonpavel previously approved these changes Mar 3, 2025
Copy link
Collaborator

@salamonpavel salamonpavel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

lsulak
lsulak previously approved these changes Mar 3, 2025
Copy link
Collaborator

@lsulak lsulak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 1 comment about code doc, otherwise LGTM

@benedeki benedeki self-assigned this Mar 3, 2025
@benedeki benedeki dismissed stale reviews from lsulak and salamonpavel via 16cb44e March 3, 2025 11:34
@benedeki benedeki merged commit 39e500a into master Mar 3, 2025
8 of 9 checks passed
@benedeki benedeki deleted the feature/246-implement-basics-of-paritioningreader branch March 3, 2025 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement basics of ParitioningReader
3 participants