-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#246: Implement basics of ParitioningReader #323
Merged
benedeki
merged 63 commits into
master
from
feature/246-implement-basics-of-paritioningreader
Mar 3, 2025
Merged
#246: Implement basics of ParitioningReader #323
benedeki
merged 63 commits into
master
from
feature/246-implement-basics-of-paritioningreader
Mar 3, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* created new module Info * the new modul added to JaCoco and CI routines
* JaCoCo exclusion for model
* created Provider to query the data from server * support for Future, IO, and ZIO based providers * work in progress
* fixed license headers
…endpoints-from-info-module
…endpoints-from-info-module
* addressed PR comments
… data * `AdditionalDataItemDTO` value filed cannot be optional anymore * _Agent_ uses the shared `ApiPath` constants * Several endpoints made visible in Swagger documentation
JaCoCo model module code coverage report - scala 2.13.11
|
JaCoCo agent module code coverage report - scala 2.13.11
|
JaCoCo reader module code coverage report - scala 2.13.11
|
JaCoCo server module code coverage report - scala 2.13.11
|
salamonpavel
previously approved these changes
Mar 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
lsulak
reviewed
Mar 3, 2025
reader/src/main/scala/za/co/absa/atum/reader/PartitioningReader.scala
Outdated
Show resolved
Hide resolved
lsulak
previously approved these changes
Mar 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just 1 comment about code doc, otherwise LGTM
…ttps://github.com/AbsaOSS/atum-service into feature/246-implement-basics-of-paritioningreader
lsulak
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PartitioningReader
methods to retrieve checkpoints and additional dataAdditionalDataItemDTO
value filed cannot be optional anymoreApiPath
constantsCloses #246
Release notes:
PartitioningReader
implemented to return the checkpoints (requested and returned in a paginated form) and additional data.