Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#43: DBTestSuite: parametrize persist_data into constructor #46

Conversation

benedeki
Copy link
Contributor

@benedeki benedeki commented Oct 16, 2024

  • make it easy to override data persistence in the DBTestSuite class, without the need to override functions.

Closes #43

Release Notes:

  • easier override of the data persistence within DBTestSuite instance via constructor parameter (no need to function overrides)

* make it easy to override data persitence in the `DBTestSuite` class, without the need to override functions.
Copy link

github-actions bot commented Oct 16, 2024

JaCoCo 'balta' module code coverage report - scala 2.12.18

Overall Project 62.73% -3.13% 🍏
Files changed 8.43% 🍏

File Coverage
DBTestSuite.scala 24.2% -48.41% 🍏

Copy link
Collaborator

@miroslavpojer miroslavpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • pulled
  • code review done
  • run all tests

Copy link
Collaborator

@miroslavpojer miroslavpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • pulled
  • code review
  • test run

miroslavpojer
miroslavpojer previously approved these changes Oct 22, 2024
@benedeki benedeki merged commit 83ade05 into master Oct 23, 2024
8 checks passed
@benedeki benedeki deleted the feaature/43-dbtestsuite-parametrize-persist_data-into-constructor branch October 23, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DBTestSuite: parametrize persist_data into constructor
2 participants