Skip to content

Conversation

@lsulak
Copy link
Collaborator

@lsulak lsulak commented Nov 4, 2025

As the title says. Tiny one.

Summary by CodeRabbit

  • Chores
    • Updated editor configuration to enforce consistent formatting rules across TypeScript, Markdown, and SQL files with line length limits and newline handling.
    • Enhanced Git binary file handling for image, font, archive, and document formats.
    • Streamlined repository ignore patterns to focus on essential IDE and build artifacts.

@coderabbitai
Copy link

coderabbitai bot commented Nov 4, 2025

Walkthrough

Configuration files updated across three key areas: EditorConfig now enforces TypeScript file formatting with 120-character line limits and includes SQL support; GitAttributes marks additional file types as binary for proper Git handling; .gitignore is simplified to retain only essential IDE and build artifact rules.

Changes

Cohort / File(s) Summary
Editor formatting rules
.editorconfig
Added TypeScript (.ts) to global web/JS suite with 120-character line length limit. Modified Markdown block to enforce max_line_length = 120 and insert_final_newline = true. Introduced new SQL/DDL block (.sql, *.dd) with 4-space indentation, CRLF line endings, and 120-character line length.
Git binary file handling
.gitattributes
Classified five additional file types as binary: *.png, *.ttf, *.jar, *.pdf, *.pptx. Prevents text normalization for these files in Git operations.
Git ignore rules
.gitignore
Consolidated rules by removing broad ignore patterns (*.ser, *.class, *~, *.bak, editor/build sections). Retained minimal essentials: IDE configuration (/.idea, *.iml), build artifacts (target, .bsp), and project-specific entries.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Verify that .gitignore simplification aligns with project intent and doesn't inadvertently track unwanted files
  • Confirm SQL/DDL formatting rules (CRLF, 120-char limit) match project standards
  • Ensure binary file classifications don't conflict with existing Git configuration

Poem

🐰 Configs refined with care today,
TypeScript joins the formatting way,
SQL and binaries find their place,
Ignores trimmed down with grace,
Repository rules now neat—hooray! 🎉

Pre-merge checks and finishing touches

✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'updating dot files from CPS Handbook' accurately describes the main change: configuration file updates across .editorconfig, .gitattributes, and .gitignore based on handbook guidelines.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/updating-dot-files-from-cps-handbook

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b6ef2df and 06b6dfd.

📒 Files selected for processing (3)
  • .editorconfig (1 hunks)
  • .gitattributes (1 hunks)
  • .gitignore (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
  • GitHub Check: Build, Test and Doc (2.13.12)
  • GitHub Check: Build, Test and Doc (2.12.17)
  • GitHub Check: Build, Test and Measure
  • GitHub Check: Build, Test and Doc (2.13.12)
  • GitHub Check: Build, Test and Doc (2.12.17)
🔇 Additional comments (5)
.gitattributes (1)

30-36: Binary file type classifications look good.

The additions correctly mark these common binary formats for proper Git handling.

.editorconfig (3)

29-33: TypeScript inclusion is appropriate.

Adding ts to the JavaScript/JSON/CSS pattern aligns well with modern development practices.


35-37: Markdown formatting rules look reasonable.

The max_line_length and final-newline insertion rules are consistent with the rest of the configuration.


39-44: Clarify intent behind CRLF for SQL files.

The new SQL/DDL section uses end_of_line = crlf, which conflicts with the global LF default (line 21). This is unusual in a Unix/Linux-based repository unless SQL scripts are specifically targeted at Windows environments. Verify this is intentional and aligns with your development/deployment practices.

.gitignore (1)

17-22: Redundant .idea patterns—clarify intent.

Lines 17 and 20 both target the .idea directory but with different match scopes: /.idea (root-only) and .idea (anywhere). The more permissive /.idea pattern makes .idea on line 20 redundant. Confirm whether both are intentional or if one should be removed.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@lsulak lsulak self-assigned this Nov 4, 2025
@github-actions
Copy link

github-actions bot commented Nov 4, 2025

JaCoCo core module code coverage report - scala 2.13.11

Overall Project 57.47% 🍏

There is no coverage information present for the Files changed

@github-actions
Copy link

github-actions bot commented Nov 4, 2025

JaCoCo doobie module code coverage report - scala 2.13.11

Overall Project 70.17% 🍏

There is no coverage information present for the Files changed

@github-actions
Copy link

github-actions bot commented Nov 4, 2025

JaCoCo slick module code coverage report - scala 2.13.11

Overall Project 91.42% 🍏

There is no coverage information present for the Files changed

salamonpavel
salamonpavel previously approved these changes Nov 5, 2025
@lsulak lsulak added the no RN No release notes required label Nov 5, 2025
ABLL526
ABLL526 previously approved these changes Nov 5, 2025
Copy link
Contributor

@ABLL526 ABLL526 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to achieve what is needed. LGTM.

@lsulak lsulak dismissed stale reviews from ABLL526 and salamonpavel via 764090d November 10, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no RN No release notes required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants