Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/fix to use correct syntax #8

Merged
merged 46 commits into from
Jul 31, 2024

Conversation

miroslavpojer
Copy link
Collaborator

@miroslavpojer miroslavpojer commented Jun 21, 2024

Added support and examples for multiline inputs.
Update doc files.

Closes #3

@miroslavpojer miroslavpojer requested a review from lsulak June 21, 2024 12:54
@miroslavpojer miroslavpojer self-assigned this Jun 21, 2024
@miroslavpojer
Copy link
Collaborator Author

miroslavpojer commented Jun 21, 2024

Release notes:

  • added support for multi-line inputs support and examples: name-patterns, paths, excludes
  • update of doc file:
    • glob patterns support for path - for finding of files (support **)
    • fnmatch patterns support for name-patterns and excludes (do no support **)

@miroslavpojer miroslavpojer added enhancement New feature or request work in progress Work on this item is not yet finished (mainly intended for PRs) labels Jul 8, 2024
@miroslavpojer miroslavpojer requested a review from benedeki July 9, 2024 11:48
@miroslavpojer miroslavpojer removed the work in progress Work on this item is not yet finished (mainly intended for PRs) label Jul 9, 2024
@miroslavpojer miroslavpojer requested review from Zejnilovic, MobiTikula and lsulak and removed request for Zejnilovic July 9, 2024 11:49
@miroslavpojer miroslavpojer requested a review from dk1844 July 30, 2024 07:50
Copy link

@dk1844 dk1844 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (I just had a few comments, but non-blocking, really)

.github/workflows/integration_tests.yml Outdated Show resolved Hide resolved
src/filename_inspector.py Outdated Show resolved Hide resolved
src/filename_inspector.py Show resolved Hide resolved

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty file is confusing. Would put there a comment explaining it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in commit e7f9298.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing licenses in file headers?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in commit e7f9298.

@miroslavpojer miroslavpojer requested review from benedeki and dk1844 July 31, 2024 06:42
@miroslavpojer miroslavpojer merged commit eaa3307 into master Jul 31, 2024
3 checks passed
@miroslavpojer miroslavpojer deleted the feature/fix-to-use-correct-syntax branch July 31, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for wildcards in file paths
3 participants