Standardize handling of directories and paths in ci_steps.yml #2066
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than explicitly stating each step's working directory, use use BUILD_DIR and INSTALL_DIR env vars. It's easier to follow this way. Also, Windows requires explicitly setting the PATH before running ctest and before executing the website example. Set OPENEXR_PATH to have the necessary components. Because the PATH can get modified internally by GitHub actions, it's easiest to gather the path setting into a variable and set it explicitly just before execution. This also renames the "ubuntu" install manifests to "linux". Signed-off-by: Cary Phillips <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than explicitly stating each step's working directory, use use BUILD_DIR and INSTALL_DIR env vars. It's easier to follow this way.
Also, Windows requires explicitly setting the PATH before running ctest and before executing the website example. Set OPENEXR_PATH to have the necessary components. Because the PATH can get modified internally by GitHub actions, it's easiest to gather the path setting into a variable and set it explicitly just before execution.
This also renames the "ubuntu" install manifests to "linux".
This also adds a check to the step that builds the website example to validate that exrinfo produces the expected results.
Website preview: https://openexr--2066.org.readthedocs.build/en/2066/