feat: CP-1068 Create MCP tool to bump timestamp of a project #3713
Conversation
| Script: bumpedBS, | ||
| }) | ||
| if err != nil { | ||
| return errs.Wrap(err, "Failed to stage bumped commit") |
There was a problem hiding this comment.
When it does not solve, it errors here.
e.g.:
`Failed to stage bumped commit:
failed to poll build plan:
Request failed: Could not plan build. Platform responded with:
These are the last lines of the error message:
….2.36) requires Ingredient|language/python|fast-agent-mcp (0.2.36) which depends on Feature|language/python|opentelemetry-instrumentation-google-genai (>=0.2b0), Feature|language/python|fast-agent-mcp (0.2.36) requires Feature|language/python|opentelemetry-instrumentation-google-genai (>=0.2b0).
So, because no versions of Feature|language/python|opentelemetry-instrumentation-google-genai match >=0.2b0
and root depends on Feature|language/python|fast-agent-mcp (0.2.36), version solving failed.`
| } | ||
| } | ||
|
|
||
| func (runner *ProjectErrorsRunner) Run(params *Params) error { |
There was a problem hiding this comment.
This func is based off of /internal/runners/upgrade/upgrade.go
It isn't bumping the timestamp and I don't know why yet. Perhaps it's missing something after StageCommitAndPoll
| return fmt.Errorf("error fetching default branch: %w", err) | ||
| } | ||
|
|
||
| // Collect "before" buildplan |
There was a problem hiding this comment.
| // Collect "before" buildplan | |
| // Collect "before" buildscript |
| return errs.Wrap(err, "Failed to fetch build result") | ||
| } | ||
|
|
||
| // Collect "after" buildplan |
There was a problem hiding this comment.
| // Collect "after" buildplan | |
| // Collect "after" buildscript |
| now := captain.TimeValue{} | ||
| now.Set("now") | ||
| ts, err := commits_runbit.ExpandTime(&now, runner.auth) | ||
| if err != nil { | ||
| return errs.Wrap(err, "Failed to fetch latest timestamp") | ||
| } | ||
| bumpedBS.SetAtTime(ts, true) |
There was a problem hiding this comment.
This is for facilitating flag parsing, it's a roundabout way of grabbing the time if you already know that you want "now". In this case you can just call the underlying logic:
cli/internal/runbits/commits_runbit/time.go
Lines 32 to 37 in 7301bd9
I wouldn't expect to see any use of the captain package in mcp tooling, that's specifically for command line handling, so a red flag.
| "github.com/ActiveState/cli/pkg/project" | ||
| ) | ||
|
|
||
| type ProjectErrorsRunner struct { |
There was a problem hiding this comment.
Please rename to reflect directory name.
| type Params struct { | ||
| project *project.Namespaced | ||
| } | ||
|
|
||
| func NewParams(project *project.Namespaced) *Params { | ||
| return &Params{ | ||
| project: project, | ||
| } | ||
| } |
There was a problem hiding this comment.
Please make Project public. And nitpick but NewParams() should not take any of the params if we are to stick to the pattern.
When interacting with runners via the CLI (ie. via captain) we use params to pass properties by reference, which we can't do if they're private and only provided as arguments to a constructor function.
Uh oh!
There was an error while loading. Please reload this page.