Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests, by using a different type to parse outgoing/incoming #4

Merged
merged 2 commits into from
May 21, 2021
Merged

Fix tests, by using a different type to parse outgoing/incoming #4

merged 2 commits into from
May 21, 2021

Conversation

benjamin-actyx
Copy link
Contributor

Could also parameterize Outgoing but imo not worth the complication. We should rather get the approach in #1 working at some point.

@aruediger
Copy link
Contributor

gonna reopen to trigger the checks

@aruediger aruediger closed this May 21, 2021
@aruediger aruediger reopened this May 21, 2021
aruediger
aruediger approved these changes May 21, 2021
View reviewed changes
Copy link
Contributor

@aruediger aruediger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙂

@benjamin-actyx benjamin-actyx merged commit 0377239 into master May 21, 2021
@benjamin-actyx benjamin-actyx deleted the bsi/fix-tests branch May 21, 2021 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aruediger aruediger aruediger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benjamin-actyx @aruediger