Skip to content

Add check for buffer bound #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Add check for buffer bound #55

wants to merge 11 commits into from

Conversation

raz-adroll
Copy link
Collaborator

No description provided.

abijr
abijr reviewed Jun 20, 2025
View reviewed changes
Copy link

@abijr abijr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test for when the buffer is out of bounds, validate that we're emitting the error correctly?

@raz-adroll
Copy link
Collaborator Author

Can we add a test for when the buffer is out of bounds, validate that we're emitting the error correctly?

Unfortunately, I don't have enough memory for that.
What I suspect is that at some point, it was trying to access invalid memory and that was giving us an invalid memory size.
How that happened is unknown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abijr abijr abijr left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raz-adroll @abijr