Open
Conversation
Collaborator
CalculatorWhat We're Looking For
Goeun! Great work on this project. The code looks great! The project works as expected, too. Overall, I think that you did a great job writing clean code, it's well organized, the solution is appropriate, appropriately simple and not over-complicated, and easy to read. I think you hit all the learning goals. I'm adding a small comment as an improvement, but otherwise I think you did great. Good work! |
tildeee
reviewed
Aug 12, 2018
| until second_number.to_i.to_s == second_number | ||
| puts "That's not an integer! Please input an integer:" | ||
| second_number = gets.chomp | ||
| end |
Collaborator
There was a problem hiding this comment.
The code for getting the input for first_number and second_number end up looking very similar. Is there a way that it can turn into a method that you reuse? ;)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calculator
Congratulations! You're submitting your assignment.
Comprehension Questions