Skip to content

Goeun - Calculator - Edges #36

Open
goeunpark wants to merge 1 commit intoAda-C10:masterfrom
goeunpark:master
Open

Goeun - Calculator - Edges #36
goeunpark wants to merge 1 commit intoAda-C10:masterfrom
goeunpark:master

Conversation

@goeunpark
Copy link

Calculator

Congratulations! You're submitting your assignment.

Comprehension Questions

Question Answer
Describe how you stored user input in your program? I stored user input using gets.chomp into variables operator, first_number, and second_number
How did you determine what operation to perform? I added the required operations (+, -, *, /) then added exponent (**) and modulo (%)
Do you feel like you used consistent indentation throughout your code? Yes
If you had more time, what would you have added to or changed about the program? I would have tried to implement the last three optional enhancements and search how to repeat the code so user can calculate again

@tildeee
Copy link
Collaborator

tildeee commented Aug 12, 2018

Calculator

What We're Looking For

Feature Feedback
Takes in two numbers and an operator and performs the mathematical operation. x
Readable code with consistent indentation. x

Goeun! Great work on this project.

The code looks great! The project works as expected, too. Overall, I think that you did a great job writing clean code, it's well organized, the solution is appropriate, appropriately simple and not over-complicated, and easy to read. I think you hit all the learning goals.

I'm adding a small comment as an improvement, but otherwise I think you did great. Good work!

until second_number.to_i.to_s == second_number
puts "That's not an integer! Please input an integer:"
second_number = gets.chomp
end
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code for getting the input for first_number and second_number end up looking very similar. Is there a way that it can turn into a method that you reuse? ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants