Skip to content

Michelle - Edges - Exquisite React #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
kangazoom wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Michelle - Edges - Exquisite React #21

kangazoom wants to merge 15 commits into from

Conversation

@kangazoom
Copy link

@kangazoom kangazoom commented Dec 14, 2018 •
edited
Loading

Exquisite React

Congratulations! You're submitting your assignment.

Comprehension Questions

Feature Feedback
How did this project differ from in-class examples? It required a bit more work in terms of showing/hiding and one of the components built off of another one, although they were not nested (RecentSubmission and FinalPoem)
How was this project similar to in-class examples? It relied on components, had similar callbacks, and involved form handling similar to examples we had covered.
If you had time to refactor one part of this project, what would you do to make it better? I missed the FIELDS array when I started, so my work on PlayerSubmissionForm could be greatly refactored.
note: sorry this is a few hours late - i've been under the weather!

@kangazoom
ran npm install to set up
2ab01a5
@kangazoom
made PlayerSubmissionForm controlled + registers state changes when u…
ec6dff7 
…ser types
@kangazoom
added feature where user can submit lines of poetry - can view under …
ed3383c 
…'recent submissions' + keeps track of user #
@kangazoom
moved RecentSubmission logic into FinalPoem and made RecentSubmission…
811adba 
… appear 1x in Game
@kangazoom
left notes to prep for showing/hiding elements
535ba04
@kangazoom
moved stuff around (tried to lift poem line view to Game to make thin…
6ee87c4 
…gs DRY-er); final poem looks better - still need to hide/show
@kangazoom
reveal poem button shows up appropriately
c9eb280
@kangazoom
reveal poem button functionality works to show finished poem
96265c5
@kangazoom
feature to show final poem and hide other components now works
9c2862e
@kangazoom
edited logic to hide reveal poem button when viewing full poem
361b44e
@kangazoom
text inputs in form show as pink if nothing is entered
2758d25
@kangazoom
started clean up + fixed bug where recent submission header was alway…
55ae6df 
…s shown
@kangazoom
in Game, made some more render variables to use in ternaries
06ae8e9
@kangazoom
moved logic to show final poem component up into Game
e4dc358
@kangazoom
clean up and added some notes for refactoring in Game
9a55b01
@kangazoom kangazoom changed the title Michelle - Edges Exquisite React Michelle - Edges - Exquisite React Dec 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@kangazoom