hotel project - jessie zhang by jessiezhang2017 · Pull Request #25 · Ada-C10/hotel

jessiezhang2017 · 2018-09-10T08:00:21Z

Hotel

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
Describe a design decision you had to make when working on this project. What options were you considering? What helped you make your final decision?	I need to decide if I want to create a child class Block to inherit the Admin class , to help solve the wave 3 room-block issue. Or, I can just create methods within the Admin class to solve the problem. I decide to create a Block class , since looks it can save me some time . I also need to decide if I want to generate an instance attribute to hold a list of the available room with date hash. or, I can work on the list of reservations directly. I decide to create the list of available room with data hash. It seems more direct, and can help to build create room-block method in wave three.
Describe a concept that you gained more clarity on as you worked on this assignment.	I understand more how to use inheritance .
Describe a nominal test that you wrote for this assignment.	for create_room_block method, a nominal test would be returns a new object of Block , or remove the related rooms from the room_unbooked_dates array in the specified date
Describe an edge case test that you wrote for this assignment.	an_edge case would be raise ArgumentError if the period requested for set up room block is outside of the current working period.
How do you feel you did in writing pseudocode first, then writing the tests and then the code?	I did not have that habit before, but after I tried, I think it help to make me thinking more thoroughly before I start to write the tests.

…om class

…nitialize method

…e method too

…ethod

…te the make_reservation method accordingly

…ch is available

CheezItMan · 2018-09-17T04:10:07Z

Hotel

What We're Looking For

Feature	Feedback
Baseline
Used git regularly	Good number of commits, but you sometimes use waves in your commit messages. Stick to describing the functionality added. Otherwise good commit messages
Answer comprehension questions	Check
Design
Each class is responsible for a single piece of the program	Check, although Block can do Admin functions which makes little sense.
Classes are loosely coupled	Block and Admin are tightly coupled
Wave 1
List rooms	Check
Reserve a room for a given date range	Check
List reservations for a given date	Check
Calculate reservation price	Check
Invalid date range produces an error	Check
Test coverage	98%
Wave 2
View available rooms for a given date range	Check
Reserving a room that is not available produces an error	Check
Wave 3
Create a block of rooms	Check, but awkwardly done with inheritance
Check if a block has rooms	Check
Reserve a room from a block	Check, but it's using Admin functionality
Fundamentals
Names variables, classes and modules appropriately	Check
Understanding of variable scope - local vs instance	Check
Can create complex logical structures utilizing variables	Check
Appropriately uses methods to break down tasks into smaller simpler tasks	Check
Understands the differences between class and instance methods	Check
Appropriately uses iterators and enumerables	Check
Appropriately writes and utilizes classes	Check, but I think you are misusing inheritance
Appropriately utilizes modules as a mechanism to encapsulate functionality	No module used
Wrap Up
There is a refactors.txt file	MISING
The file provides a roadmap to future changes	MISING
Additional Feedback	Creative solution to keeping a list of dates. It's not space-efficient, but somewhat easier to code. You have some pretty good testing. You also have some good breakout of functionality, but as I noted several times making Block a child class of Admin, is a little odd. I left some comments inline in your code, let me know if you have questions. Overall well done.

CheezItMan · 2018-09-17T03:56:53Z

lib/admin.rb

+  end
+
+  # make new reservations
+  def make_reservation(reservation_id, customer_name, start_date, end_date)


Why do you need a reservation_id to make a reservation?

CheezItMan · 2018-09-17T03:57:53Z

lib/admin.rb

+
+  # input a string of date, to return the list of the reservations on that date
+  def list_reservations(date_selected)
+    return @reservations.select {|reserve| reserve.dates_booked.include? date_selected}


CheezItMan · 2018-09-17T03:58:48Z

lib/block_admin.rb

+require_relative 'room'
+require_relative 'admin'
+
+class Block < Admin


Is a Block and Admin? Why make it a subclass?

CheezItMan · 2018-09-17T03:59:09Z

lib/main.rb

@@ -0,0 +1,19 @@
+require 'pry'


This file is unnecessary in the project.

CheezItMan · 2018-09-17T04:00:46Z

spec/admin_spec.rb

+
+    it "will not create a reservation if no room is available" do
+
+      expect(@admin_1.reservations.length).must_equal 22


This test isn't trying to create a reservation

CheezItMan · 2018-09-17T04:01:50Z

spec/admin_spec.rb

+
+    end
+
+    it "returns nil if no result being found" do


not nil an empty array.

CheezItMan · 2018-09-17T04:02:12Z

spec/admin_spec.rb

+
+    it "if result being found, must return an array of resrvations " do
+       expect(@admin_1.list_reservations(Date.new(2018,12,5))).must_include @res_1
+       expect(@admin_1.list_reservations(Date.new(2018,12,5))).must_include @res_2


You should also verify that they're all reservations.

…from the parameters to generate new reservation instance

jessiezhang2017 added 19 commits September 4, 2018 14:55

Add coverage directory to .gitignore file

812d5ff

set up the room class and the initialize method

fc90cbb

add the initialize method for reservation.rb

d8195c6

changed the hotel.rb to admin.rb , added add_reservation method in ro…

4c9bec1

…om class

add a dates_booked method in reservation class

5e3f9b0

finish the initialize for Admin class

8f3294b

remove add_reservation method from room.rb, changed reservation.rb i…

a3835a3

…nitialize method

complete the add_reserve_date method in room.rb, adjust the initializ…

2113788

…e method too

add make_reservation method in admin.rb

54e9502

finish list reservations on a date and return the reservation cost m…

65b3d8a

…ethod

finish wave 1

7dea527

add @room_unbooked_dates as the instance attribut for admin.rb, upda…

7e10ae1

…te the make_reservation method accordingly

complete the room_available_list in a given date range method

8ff8351

update make_reservaion method to allow system pick the first room whi…

548059f

…ch is available

change the admin.rb initailze method to add more parameters

a2925c1

add a BlockAdmin class which is a child class of Admin class

dcf4a38

finished create_room_block method in admin.rb

8505abe

add a main.rb for test run purpose

87de2a4

change a typo

6f563a7

CheezItMan reviewed Sep 17, 2018

View reviewed changes

jessiezhang2017 added 3 commits September 30, 2018 08:43

added sesign-activity.md

9b71615

add the change plan to design-activity.md

0d2503d

remove main.rb, change the block class to be indepentaant, remove id …

d44bbac

…from the parameters to generate new reservation instance

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

hotel project - jessie zhang#25

hotel project - jessie zhang#25
jessiezhang2017 wants to merge 22 commits intoAda-C10:masterfrom
jessiezhang2017:master

jessiezhang2017 commented Sep 10, 2018

Uh oh!

CheezItMan commented Sep 17, 2018

Uh oh!

CheezItMan Sep 17, 2018

Uh oh!

CheezItMan Sep 17, 2018

Uh oh!

CheezItMan Sep 17, 2018

Uh oh!

CheezItMan Sep 17, 2018

Uh oh!

CheezItMan Sep 17, 2018

Uh oh!

CheezItMan Sep 17, 2018

Uh oh!

CheezItMan Sep 17, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants


		it "will not create a reservation if no room is available" do

		expect(@admin_1.reservations.length).must_equal 22

Comments

Conversation

jessiezhang2017 commented Sep 10, 2018

Hotel

Comprehension Questions

Uh oh!

CheezItMan commented Sep 17, 2018

Hotel

What We're Looking For

Uh oh!

CheezItMan Sep 17, 2018

Choose a reason for hiding this comment

Uh oh!

CheezItMan Sep 17, 2018

Choose a reason for hiding this comment

Uh oh!

CheezItMan Sep 17, 2018

Choose a reason for hiding this comment

Uh oh!

CheezItMan Sep 17, 2018

Choose a reason for hiding this comment

Uh oh!

CheezItMan Sep 17, 2018

Choose a reason for hiding this comment

Uh oh!

CheezItMan Sep 17, 2018

Choose a reason for hiding this comment

Uh oh!

CheezItMan Sep 17, 2018

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants