LJ Hotel by elle-johnnie · Pull Request #33 · Ada-C10/hotel

elle-johnnie · 2018-09-10T15:41:18Z

Hotel

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
Describe a design decision you had to make when working on this project. What options were you considering? What helped you make your final decision?	I went back in forth between attempting a BookingSystem module and BookingSystem class. I ended up going the class route since I was exactly sure how to implement mixins .
Describe a concept that you gained more clarity on as you worked on this assignment.	I think I gained more understanding of duck typing. The concept didn't make much sense to me prior to this assignment, but while building it and sending messages between classes I feel like I improved my understanding of the concept.
Describe a nominal test that you wrote for this assignment.	A reservation can be instantiated.
Describe an edge case test that you wrote for this assignment.	An argument error is raised if all rooms are booked.
How do you feel you did in writing pseudocode first, then writing the tests and then the code?	I did well for the most part. I find it usually helps in the initial building stage of the project. I did find that as I was playing around with block bookings that I felt I just needed to start with code instead of tests since I wasn't sure exactly what I thought it should look like if I approached it first from the test build perspective. I likely would have benefited from pseudocoding this out, but running short on time I jumped straight into building the methods and refactoring others to get block reservations to work.

…o pass tests

…vations

…n't figure out tests for both no method error

…_dates to attr_reader in Reservation - duh - tests are built and now working

…n#get_reservation_total

…tion#methods to BookingSystem for better handling

…ering Reservation overhaul

…o booking_system_spec - tests pass

…class methods, added room csv

…added test and BlockReservation class

CheezItMan · 2018-09-17T01:28:38Z

Hotel

What We're Looking For

Feature	Feedback
Baseline
Used git regularly	Good number of commits and good commit messages
Answer comprehension questions	Check, I'm glad Duck Typing make more sense now.
Design
Each class is responsible for a single piece of the program	Check
Classes are loosely coupled	Check
Wave 1
List rooms	Check
Reserve a room for a given date range	Check
List reservations for a given date	Check
Calculate reservation price	Check
Invalid date range produces an error	Check
Test coverage	99.7%
Wave 2
View available rooms for a given date range	Check
Reserving a room that is not available produces an error	No check for this
Wave 3
Create a block of rooms	Check
Check if a block has rooms	Check, inherited from `Reservation`
Reserve a room from a block	No way to reserve a room within a block
Fundamentals
Names variables, classes and modules appropriately	Check
Understanding of variable scope - local vs instance	Check
Can create complex logical structures utilizing variables	Check
Appropriately uses methods to break down tasks into smaller simpler tasks	Check
Understands the differences between class and instance methods	Check, but see my notes in `room.rb`
Appropriately uses iterators and enumerables	Very well done
Appropriately writes and utilizes classes	Check
Appropriately utilizes modules as a mechanism to encapsulate functionality	Check
Wrap Up	Will complete later
There is a refactors.txt file
The file provides a roadmap to future changes
Additional Feedback	Very well done. Nice work. You hit all the learning goals and got to wave 3. I like the design and how things are laid out. See my inline notes, but very well done. You wrote some really good tests, nice work!

CheezItMan · 2018-09-17T01:10:12Z

lib/room.rb

Do you really want cost to be an accessor?

CheezItMan · 2018-09-17T01:11:27Z

lib/room.rb

This method doesn't make much sense because your self.all method doesn't initialize an @@id class variable, and in your @id instance variable the instance variable is just a number not a list.

CheezItMan · 2018-09-17T01:13:21Z

lib/reservation.rb

+      (rsv_start...rsv_end).to_a.map { |day| day.to_s }
+    end
+
+    def get_total_cost(included_rooms, rsv_start, rsv_end, status)


You could do this method with the instance variables instead of using parameters.

Also it's neat how you have a Reservation which can have multiple rooms.

CheezItMan · 2018-09-17T01:15:02Z

lib/booking_system.rb

+        reservation.booked_dates.include? search_date.to_s
+      end
+      # search through block id's if not found in standard reservations
+      if found_reservations.empty?


Why do this if it doesn't find reservations during that date. Instead you would always want to find both.

CheezItMan · 2018-09-17T01:15:23Z

lib/booking_system.rb

Why return 0 if no reservations? Why not return an empty list?

CheezItMan · 2018-09-17T01:16:10Z

lib/booking_system.rb

+    end
+
+    # method to return total cost based on reservation id
+    def get_reservation_total(id)


This method seems to duplicate existing functionality.

CheezItMan · 2018-09-17T01:16:37Z

lib/booking_system.rb

+          unavailable_rooms << rsv.included_rooms
+        end
+      end
+      available_rooms = all_rooms_arr - unavailable_rooms.flatten


CheezItMan · 2018-09-17T01:18:35Z

lib/block_reservation.rb

+      super(input)
+      raise ArgumentError, 'Invalid name' if input[:group_name].nil? || input[:group_name].empty?
+      raise ArgumentError, 'Invalid # of rooms' if input[:room_qty].to_i < 2 || input[:room_qty].to_i > 5
+      @included_rooms = input[:included_rooms]


You should also be able to make reservations from within a block, after the block is "held."

CheezItMan · 2018-09-17T01:21:08Z

lib/booking_system.rb

+
+    def make_a_reservation(guest, check_in, check_out, number_of_rooms = 1, status = :BASE)
+      raise ArgumentError, 'Too many rooms' if number_of_rooms > 20 || !(number_of_rooms.is_a? Integer)
+      open_rooms = find_available_rooms(check_in, check_out).first(number_of_rooms)


What happens if there are not enough available rooms?

CheezItMan · 2018-09-17T01:26:20Z

spec/booking_system_spec.rb

+    it 'can find available rooms given a check in and check out date' do
+      check_in = "October 23 2019"
+      check_out = "October 24 2019"
+      expect(admin.find_available_rooms(check_in, check_out)).must_be_kind_of Array


You could also check and verify each instance is a Room

elle-johnnie added 18 commits September 4, 2018 13:33

Add coverage and idea directories to .gitignore

4340bd2

Hotel module created with room_spec and room.rb - tests pass

7e48e05

added default cost and default booked_dates tests and modified code t…

60dab85

…o pass tests

added reservation_spec tests and reservation.rb

7ac1cfd

added sample reservation data csv and tests for reservation#all_reser…

56c88b4

…vations

test and reservation#all_reservations loading csv

41a3e1a

added load csv data tests to ensure correct parsing of data

944d2bb

added Reservations#get_date_range and Reservation#get_total_cost - ca…

54bdfa0

…n't figure out tests for both no method error

resolved no method issues in last commit via adding status and booked…

acee41d

…_dates to attr_reader in Reservation - duh - tests are built and now working

tests and method built for Reservation#find_all_reservation

38257d1

added tests and methods Reservation#find_a_reservation and Reservatio…

dae2bd0

…n#get_reservation_total

added tests to find available rooms - considering moving many Reserva…

7fcbd4b

…tion#methods to BookingSystem for better handling

Reservation#find_available_rooms completed passes test - still consid…

4220b0a

…ering Reservation overhaul

moved all reservation queries to BookingSystem class and test files t…

b0b0f52

…o booking_system_spec - tests pass

refactor booking_system class - intitialize an instance

9868b3b

refactored all classes, improved BookingSystem to eliminate numerous …

f1a8bd1

…class methods, added room csv

finished test and method build for BookingSystem#make_a_reservation, …

2170d50

…added test and BlockReservation class

what's done is done

532d3ca

CheezItMan reviewed Sep 17, 2018

View reviewed changes

elle-johnnie added 4 commits September 29, 2018 11:24

single responsibility worksheet complete

0b7e173

refactor.txt added

dfdd53a

hotel refactor

7229e45

hotel rsv in blocks refactored

f32d08a

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LJ Hotel#33

LJ Hotel#33
elle-johnnie wants to merge 22 commits intoAda-C10:masterfrom
elle-johnnie:master

elle-johnnie commented Sep 10, 2018

Uh oh!

CheezItMan commented Sep 17, 2018

Uh oh!

CheezItMan Sep 17, 2018

Uh oh!

CheezItMan Sep 17, 2018

Uh oh!

CheezItMan Sep 17, 2018

Uh oh!

CheezItMan Sep 17, 2018

Uh oh!

CheezItMan Sep 17, 2018

Uh oh!

CheezItMan Sep 17, 2018

Uh oh!

CheezItMan Sep 17, 2018

Uh oh!

CheezItMan Sep 17, 2018

Uh oh!

CheezItMan Sep 17, 2018

Uh oh!

CheezItMan Sep 17, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Conversation

elle-johnnie commented Sep 10, 2018

Hotel

Comprehension Questions

Uh oh!

CheezItMan commented Sep 17, 2018

Hotel

What We're Looking For

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments