Christina Hotel

[Peacegypsy]

Hotel

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
Describe a design decision you had to make when working on this project. What options were you considering? What helped you make your final decision?	What classes and how many to use, where to create objects and where to store them. I changed things around completing Wave One and ended up going in to the weeds and needing to scrap and go backwards.
Describe a concept that you gained more clarity on as you worked on this assignment.	Classes, methods, initializing, TDD , and pry.
Describe a nominal test that you wrote for this assignment.	room status being other than available or unavailable.
Describe an edge case test that you wrote for this assignment.	I didn't get as far as edge cases, but hopefully will, while i keep plugging away at it.
How do you feel you did in writing pseudocode first, then writing the tests and then the code?	it helps clarify what I wanted to write after creating the test.

[CheezItMan]

Hotel

What We're Looking For

Feature	Feedback
Baseline
Used git regularly	Good number of commits and very descriptive commit messages
Answer comprehension questions	Check
Design
Each class is responsible for a single piece of the program	You have some of the areas of the design set up, but no way to currently book reservations through the hotel admin.
Classes are loosely coupled	Check
Wave 1
List rooms	Check
Reserve a room for a given date range	The class exists, but code not written yet.
List reservations for a given date	INCOMPLETE
Calculate reservation price	Check
Invalid date range produces an error	INCOMPLETE
Test coverage	84.44%
Wave 2
View available rooms for a given date range	INCOMPLETE
Reserving a room that is not available produces an error	INCOMPLETE
Wave 3	INCOMPLETE
Create a block of rooms
Check if a block has rooms
Reserve a room from a block
Fundamentals
Names variables, classes and modules appropriately	Some names could be better. You also have multiple modules, which doesn't make sense.
Understanding of variable scope - local vs instance	You are using class variables inappropriately in some areas.
Can create complex logical structures utilizing variables	Not working
Appropriately uses methods to break down tasks into smaller simpler tasks	Several methods not working
Understands the differences between class and instance methods	Check
Appropriately uses iterators and enumerables	INCOMPLETE
Appropriately writes and utilizes classes	INCOMPLETE
Appropriately utilizes modules as a mechanism to encapsulate functionality	INCOMPLETE
Wrap Up
There is a refactors.txt file	MISSING
The file provides a roadmap to future changes	MISSING
Additional Feedback	See my inline notes, you have some pieces in place for a good design, but it looks like, as you said, that you got lost in the weeds in this project. I would suggest taking time to talk with someone to go through the design and sketch things out. For the break week, I'd suggest seeing if you could build a DateRange class with methods to determine if a date is inside the range.

[CheezItMan]

I'm not sure what purpose this method is serving, it seems to do recursion.

[CheezItMan]

Here you are setting @start_date to itself. It should probably be @start_date = start_date_time

[CheezItMan]

The idea for this class is a really good idea, but the implementation doesn't make sense.

[CheezItMan]

Since this is a class method, you shouldn't need instance variables.

[CheezItMan]

A room won't be just available or unavailable. A room's availability depends on the date.

[CheezItMan]

You should put each class in the same module. Grouping the classes into a common module is how we normally organize classes in our project.

[CheezItMan]

A room won't have a set status. The status will depend on the date as well.

[CheezItMan]

I would probably name this class Reservation