Skip to content

Trang Frego - Trek#21

Open
tfrego wants to merge 5 commits intoAda-C10:masterfrom
tfrego:master
Open

Trang Frego - Trek#21
tfrego wants to merge 5 commits intoAda-C10:masterfrom
tfrego:master

Conversation

@tfrego
Copy link

@tfrego tfrego commented Nov 26, 2018

TREK

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What does it mean for code to be asynchronous? Asynchronous code means that you can do many things at once. You can still interact with a webpage while waiting for a request/response.
Describe a piece of your code that executes asynchronously. How did this affect the way you structured it? My code executes asynchronously while loading trips, getting trip details, and posting reservations. It affected my structure based on which data was needed first before I can submit a post/get request.
What kind of errors might the API give you? How did you choose to handle them? The errors include when bad data is received or sent. The errors are displayed to the user in my status-message section.
Suppose you needed to routinely find a specific Trip in the list by it's ID field. Would it be advantageous to keep the list in order by the id field? Explain why or why not. Yes, you may want to display the most recent trips by ID. And no, if you are not concerned with the order of trips generated but want it grouped by specific fields.

@dHelmgren
Copy link

TREK

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene Good
Comprehension questions Good
Functionality
Click a button to load and view a list of trips Yes
Click a trip to load and view trip details Yes
Fill out a form to reserve a spot Yes
Errors are reported to the user Yes
CSS is DRY and attractive, uses CSS Grid, flexbox, and/or Bootstrap Yes
Under the Hood
Trip data is retrieved using from the API Yes
JavaScript is well-organized and easy to read Yes
HTML is semantic Yes
Overall Excellent job overall! This code is for the most part well-organized and easy to read, and it's clear the learning goals of this assignment were met. I especially appreciate the care you put into error handling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants