Skip to content

Conversation

@jfahmy
Copy link

@jfahmy jfahmy commented Nov 26, 2018

TREK

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What does it mean for code to be asynchronous? That there is a queue of actions that will be executed when triggered by an event. (This means that code is not necessarily executed from top to bottom. )
Describe a piece of your code that executes asynchronously. How did this affect the way you structured it? I have two click events that trigger a chain of events that include the execution of other functions - like the functions that make my axios api calls for example.
What kind of errors might the API give you? How did you choose to handle them? The api will give you an error if you do not send a post request with the necessary information. These are caught by the .catch function and I am looping through the errors and printing these to the screen above the form.
Suppose you needed to routinely find a specific Trip in the list by it's ID field. Would it be advantageous to keep the list in order by the id field? Explain why or why not. The list is currently in order by the field id! This is actually something I hadn't realized when building my project. I am retrieving the id with my api call and building the show trip get request at the time that I get the whole list of trips, but I now see that perhaps I could have separated this show request creation, and called up a show event only when needed using the id that marks it's order in the list. I'm unsure of the disadvantages of the way I've structured my code for this - would love to hear your insight.

@CheezItMan
Copy link

TREK

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene Great commit messages and good number of ocmmits
Comprehension questions Check, Searching for items when they are sorted can be accomplished with a binary search O(log n) instead of a linear search O(n).
Functionality
Click a button to load and view a list of trips Check
Click a trip to load and view trip details Check
Fill out a form to reserve a spot Check
Errors are reported to the user No reports of network errors, for example, View Escape Options, doesn't give a visible error message when the API is unreachable. Similar issues for showing trip details. The reserving trips does show error messages for validation fields.
CSS is DRY and attractive, uses CSS Grid, flexbox, and/or Bootstrap Well done
Under the Hood
Trip data is retrieved using from the API Check
JavaScript is well-organized and easy to read Pretty well organized
HTML is semantic Check
Overall OMG I almost fell over laughing when I saw Wrecked! You hit all the learning goals for the project. Nice work!

};

const reportStatus = (message) => {
$('#status-message').html(message);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CSS is preventing this message from being visible for network issues (because the trip registration isn't visible).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants