Skip to content

lindsay - edges - trek#28

Open
elle-terch wants to merge 18 commits intoAda-C10:masterfrom
elle-terch:master
Open

lindsay - edges - trek#28
elle-terch wants to merge 18 commits intoAda-C10:masterfrom
elle-terch:master

Conversation

@elle-terch
Copy link

TREK

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What does it mean for code to be asynchronous? Different parts of the code can be doing things at the same time.
Describe a piece of your code that executes asynchronously. How did this affect the way you structured it? One example: I didn't want the axios GET request to happen until after a user clicked on the "Get Trips!" button. So I used event handlers in the $(document.ready) part of the code. This way, the HTML is loaded before the DOM can be changed, and that GET request will only be triggered by a user's click of a button.
What kind of errors might the API give you? How did you choose to handle them? A user might get an error if they try to POST a new reservation to a trip id that doesn't exist. I created a section on the page where a user would see any relevant messages (very similar to what we did in class).
Suppose you needed to routinely find a specific Trip in the list by it's ID field. Would it be advantageous to keep the list in order by the id field? Explain why or why not. If the ID is really far down the list, it probably makes more sense to implement some sort of search functionality at the top of the page that allows the user to input a trip id. You can then use the getElementById() method to surface it. The catch is that this assumes that a trip id equals the element id. For example, in my implementation, I made sure that the "Get Trip Info" button had the same id as the associated trip so I could use it as a parameter.

@tildeee
Copy link

tildeee commented Dec 12, 2018

TREK

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene x
Comprehension questions x, perfect answers!
Functionality
Click a button to load and view a list of trips x
Click a trip to load and view trip details x
Fill out a form to reserve a spot x
Errors are reported to the user x
CSS is DRY and attractive, uses CSS Grid, flexbox, and/or Bootstrap x
Under the Hood
Trip data is retrieved using from the API x
JavaScript is well-organized and easy to read x
HTML is semantic x
Overall

Lindsay!!! Your project and code look great! They work really well. I think your code style is beautiful and readable. It is very straightforward, without necessary fluff. Great work!

My only comment is that maybe your variable names URL1, URL2, etc. aren't the best names. Otherwise, I really like this submission, good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants