Dionisia - Edges - Trek

[larachan15]

TREK

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
What does it mean for code to be asynchronous?	This means that we don't have to wait for a request/response to be finished before interacting with a webpage.
Describe a piece of your code that executes asynchronously. How did this affect the way you structured it?	My reservation form appears when a trip has been clicked on. This will show the user the details of the trip and then they can reserve it, but it doesn't show until a specific trip from the trip-list has been selected.
What kind of errors might the API give you? How did you choose to handle them?	If the user did not fill out their name or email, there is a message that will let the user know that those fields are needed in order to reserve a trip.
Suppose you needed to routinely find a specific Trip in the list by it's ID field. Would it be advantageous to keep the list in order by the id field? Explain why or why not.	I am not sure I understand this question, but it does seem to make sense to keep the list sorted so that it would be easier to search. But for a user, if they had the id then I don't know if it matters, because they could always look up their trip info by the id number.

[tildeee]

TREK

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	x, it would be better to have commit messages that say the content of the changes, and not "wave 2" etc
Comprehension questions	x
Functionality
Click a button to load and view a list of trips	x
Click a trip to load and view trip details	x
Fill out a form to reserve a spot	x
Errors are reported to the user	x
CSS is DRY and attractive, uses CSS Grid, flexbox, and/or Bootstrap	x
Under the Hood
Trip data is retrieved using from the API	x
JavaScript is well-organized and easy to read	x
HTML is semantic	x
Overall

Great job on this Dionisia! The project looks good. I think that functionality-wise, your code looks pretty good.

My biggest other comment is:
Your indentation is off in a lot of places! I ask you to work on this and make it more consistent-- it will save you trouble in the future, and others!

Otherwise, I'm pretty pleased with this project submission-- great work

[tildeee]

Is trip an accurate name for this variable/parameter?

[tildeee]

:3 ?