Skip to content

Conversation

@marshi23
Copy link

TREK

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What does it mean for code to be asynchronous? Code written in such a way that it uses callback functions to send commutations to and do other things elsewhere
Describe a piece of your code that executes asynchronously. How did this affect the way you structured it? I used a callback function to handle what happens when a user clicks on a trip. I created a showTrip() function and called it inside a click() function of a trip object. I used it because it allowed me to use the ids of trips as parameters to render the required api.
What kind of errors might the API give you? How did you choose to handle them? I had a lot of issues with things not rendering on the page and variables not working. The developer tools is overwhelming at firs. the Sources window was really helpful.
Suppose you needed to routinely find a specific Trip in the list by it's ID field. Would it be advantageous to keep the list in order by the id field? Explain why or why not. Ids are unique so it makes sense to use them as identifiers. Is it possible to arrange them in order of how frequently an id is searched for?

@dHelmgren
Copy link

TREK

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene Just two commits? :'(
Comprehension questions Good
Functionality
Click a button to load and view a list of trips Yes
Click a trip to load and view trip details Yes
Fill out a form to reserve a spot Yes
Errors are reported to the user Yes
CSS is DRY and attractive, uses CSS Grid, flexbox, and/or Bootstrap Yes
Under the Hood
Trip data is retrieved using from the API Yes
JavaScript is well-organized and easy to read Yes
HTML is semantic Yes
Overall Excellent job overall! This code is for the most part well-organized and easy to read, and it's clear the learning goals of this assignment were met. I especially appreciate the care you put into error handling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants