Skip to content

Conversation

@halcyon-and-on
Copy link

TREK

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What does it mean for code to be asynchronous? the code will send off for information from some source other than itself, then wait around for a response at which point it will execute a callback that handles the data received
Describe a piece of your code that executes asynchronously. How did this affect the way you structured it? the axios api calls are all asynchronous in that they send data to the api and then have to wait around for a response from the api. one effect of this was needing to account for multiple response-cases from the api, considering i can't know in advance what it will return!
What kind of errors might the API give you? How did you choose to handle them? one example is 400 bad request for missing fields in a reservation. i just alerted the user of the error and allowed them to try again
Suppose you needed to routinely find a specific Trip in the list by it's ID field. Would it be advantageous to keep the list in order by the id field? Explain why or why not. hm yes i believe so because i could use css pseudo element selectors in jquery to grab the trip that i want (nth-child-of situation? i am assuming all id's are consecutive)

@tildeee
Copy link

tildeee commented Dec 12, 2018

TREK

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene !!!
Comprehension questions x
Functionality
Click a button to load and view a list of trips x
Click a trip to load and view trip details x
Fill out a form to reserve a spot x
Errors are reported to the user x
CSS is DRY and attractive, uses CSS Grid, flexbox, and/or Bootstrap x
Under the Hood
Trip data is retrieved using from the API x
JavaScript is well-organized and easy to read x
HTML is semantic x
Overall

Nice work on this Hayden! I think your JavaScript code is tidy and nice and easy to read! In particular, I like that you used a data- attribute (specifically data-id).

Your code looks great -- great work on this project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants