Skip to content

Conversation

@kayxn23
Copy link

@kayxn23 kayxn23 commented Nov 27, 2018

TREK

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What does it mean for code to be asynchronous? It means that the code can run 'not in sync'. So if one piece of the code runs but the response doesn't come back immediately, the next piece of code can run before the previous is completed.
Describe a piece of your code that executes asynchronously. How did this affect the way you structured it? In my code where I am using axios.post().then, this block of code executes asynchronously. So I think what is happening here is when we call axios.post(). if the post hasn't completed different parts of my program can run, for example I can click and view other trips in the meantime. There are multiple axios.get in my program, this allows the code to run as it is called rather than line by line.
What kind of errors might the API give you? How did you choose to handle them? The API gives validation errors, for example if I tried to post a reservation without an email the API would return an error indication that field is required.
Suppose you needed to routinely find a specific Trip in the list by it's ID field. Would it be advantageous to keep the list in order by the id field? Explain why or why not. Yes, because any time we search for a number in a list it is always faster to find the information if the list of numbers is sorted first.

@dHelmgren
Copy link

TREK

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene Good
Comprehension questions Good
Functionality
Click a button to load and view a list of trips Yes
Click a trip to load and view trip details Yes
Fill out a form to reserve a spot Yes
Errors are reported to the user Mostly, you're not catching errors when the page doesn't respond! Try turning network off using the network tab in dev tools!
CSS is DRY and attractive, uses CSS Grid, flexbox, and/or Bootstrap simple and functional
Under the Hood
Trip data is retrieved using from the API Yes
JavaScript is well-organized and easy to read Yes
HTML is semantic Pretty good.
Overall Solid submission! You definitely hit all the learning goals for this assignment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants