LEANNE - NODES #43
Open
LEANNE - NODES #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TREKWhat We're Looking For
|
dHelmgren
reviewed
Nov 30, 2018
|
|
||
| axios.post(postURL, sendData) | ||
| .then((response) => { | ||
| clearForm; |
There was a problem hiding this comment.
This is a function reference, not a function call, so the form isn't getting cleared.
| axios.post(postURL, sendData) | ||
| .then((response) => { | ||
| clearForm; | ||
| reportStatus(`Successfully submitted reservation ${response.data.id}!`); |
There was a problem hiding this comment.
The reportStatus function isn't able to find the element it's looking for, so it looks like nothing happens when you try to book a trip.
| <li> ${data.id} </li> | ||
| <li> ${data.category} </li> | ||
| <li> ${data.weeks} </li> | ||
| <li> ${data.cost} </li> |
| .catch((error) => { | ||
| console.log(error.response); | ||
| if (error.response.data && error.response.data.errors) { | ||
| reportStatus( |
There was a problem hiding this comment.
Again, report status isn't able to access an html element here, so nothing gets rendered.
| }; | ||
|
|
||
| const clearForm = () => { //clear out form after submission | ||
| $('form')[0].reset(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TREK
Congratulations! You're submitting your assignment!
Comprehension Questions
Tripin the list by it's ID field. Would it be advantageous to keep the list in order by the id field? Explain why or why not.